tools/telemetry/telemetry/core/backends/chrome/cros_browser_with_oobe.py - Issue 565803002: Removing browser.Start() and instead starts the browser at the point of creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_browser_with_oobe.py

Issue 565803002: Removing browser.Start() and instead starts the browser at the point of creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolve merge conflict Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py ('k') | tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/cros_browser_with_oobe.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_with_oobe.py b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_with_oobe.py

index a3d63bcae83c593736812ca4e32801d9912a895c..0899b7664df23446d14d79de378449dff1f466b5 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_with_oobe.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_with_oobe.py

@@ -8,9 +8,16 @@ from telemetry.core.backends.chrome import cros_browser_backend

class CrOSBrowserWithOOBE(browser.Browser):

"""Cros-specific browser."""

- def __init__(self, backend, platform_backend):

+ def __init__(self, backend, platform_backend, archive_path,

+ append_to_existing_wpr, make_javascript_deterministic,

+ credentials_path):

assert isinstance(backend, cros_browser_backend.CrOSBrowserBackend)

- super(CrOSBrowserWithOOBE, self).__init__(backend, platform_backend)

+ super(CrOSBrowserWithOOBE, self).__init__(backend,

+ platform_backend,

+ archive_path,

+ append_to_existing_wpr,

+ make_javascript_deterministic,

+ credentials_path)

@property

def oobe(self):