tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py - Issue 565803002: Removing browser.Start() and instead starts the browser at the point of creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

Issue 565803002: Removing browser.Start() and instead starts the browser at the point of creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolve merge conflict Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py ('k') | tools/telemetry/telemetry/core/backends/chrome/cros_browser_with_oobe.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

index 5cbdd529dd4683e076e5e337931416aee8f7c01e..16d1d4376292ae62aa077b904bb94ad306be8aba 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

@@ -49,8 +49,18 @@ class PossibleCrOSBrowser(possible_browser.PossibleBrowser):

extensions_to_load=self.finder_options.extensions_to_load)

if browser_options.create_browser_with_oobe:

return cros_browser_with_oobe.CrOSBrowserWithOOBE(

- backend, self._platform_backend)

- return browser.Browser(backend, self._platform_backend)

+ backend,

+ self._platform_backend,

+ self._archive_path,

+ self._append_to_existing_wpr,

+ self._make_javascript_deterministic,

+ self._credentials_path)

+ return browser.Browser(backend,

+ self._platform_backend,

+ self._archive_path,

+ self._append_to_existing_wpr,

+ self._make_javascript_deterministic,

+ self._credentials_path)

def SupportsOptions(self, finder_options):

if (len(finder_options.extensions_to_load) != 0) and self._is_guest: