Issue 565793005: Add exception_behaviors and its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 565793005: Add exception_behaviors and its test (Closed)

Created:
6 years, 3 months ago by Mark Mentovai

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

Add exception_behaviors and its test. This includes the functions ExceptionBehaviorHasState(), ExceptionBehaviorHasIdentity(), ExceptionBehaviorHasMachExceptionCodes(), and ExceptionBehaviorBasic(). TEST=util_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/06d48e4b0a3db2ce331193303cf4f5505d88dccc

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+215 lines, -19 lines)			Patch
M	util/mach/exc_client_variants_test.cc	View	2 chunks	+3 lines, -10 lines	0 comments	Download
M	util/mach/exc_server_variants_test.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download
A	util/mach/exception_behaviors.h	View	1 chunk	+94 lines, -0 lines	0 comments	Download
A	util/mach/exception_behaviors.cc	View	1 chunk	+39 lines, -0 lines	0 comments	Download
A	util/mach/exception_behaviors_test.cc	View	1 chunk	+70 lines, -0 lines	0 comments	Download
M	util/mach/symbolic_constants_mach.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	util/util.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

I found that I was about to add another thing that needed ExceptionBehaviorHasState(), and when ...

6 years, 3 months ago (2014-09-16 19:48:32 UTC) #2

Robert Sesek

LGTM. Nice refactoring; I did notice that code being repeated a bit frequently.

6 years, 3 months ago (2014-09-16 21:24:38 UTC) #3

Mark Mentovai

6 years, 3 months ago (2014-09-16 21:32:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 06d48e4 (presubmit successful).