Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: util/mach/exc_client_variants_test.cc

Issue 565793005: Add exception_behaviors and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/mach/exc_server_variants_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/exc_client_variants_test.cc
diff --git a/util/mach/exc_client_variants_test.cc b/util/mach/exc_client_variants_test.cc
index 9948f4d8840b0008baf1eb13ec58a095887ee485..c8692ab9bfb10c8a5ae1d82cc8876315ba6d77ae 100644
--- a/util/mach/exc_client_variants_test.cc
+++ b/util/mach/exc_client_variants_test.cc
@@ -22,6 +22,7 @@
#include "base/strings/stringprintf.h"
#include "gtest/gtest.h"
#include "util/mach/exc_server_variants.h"
+#include "util/mach/exception_behaviors.h"
#include "util/mach/mach_extensions.h"
#include "util/test/mac/mach_errors.h"
#include "util/test/mac/mach_multiprocess.h"
@@ -206,20 +207,12 @@ class TestExcClientVariants : public UniversalMachExcServer,
}
}
- exception_behavior_t BasicBehavior() const {
- return behavior_ & ~MACH_EXCEPTION_CODES;
- }
-
bool HasIdentity() const {
- exception_behavior_t basic_behavior = BasicBehavior();
- return basic_behavior == EXCEPTION_DEFAULT ||
- basic_behavior == EXCEPTION_STATE_IDENTITY;
+ return ExceptionBehaviorHasIdentity(behavior_);
}
bool HasState() const {
- exception_behavior_t basic_behavior = BasicBehavior();
- return basic_behavior == EXCEPTION_STATE ||
- basic_behavior == EXCEPTION_STATE_IDENTITY;
+ return ExceptionBehaviorHasState(behavior_);
}
// The behavior to test.
« no previous file with comments | « no previous file | util/mach/exc_server_variants_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698