Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 565753004: [turbofan] Some common operators are globally shared singletons. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Some common operators are globally shared singletons. TEST=compiler-unittests,cctest R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23913

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Fixes2 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -198 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-operator.h View 3 chunks +48 lines, -143 lines 0 comments Download
A src/compiler/common-operator.cc View 1 1 chunk +244 lines, -0 lines 0 comments Download
M src/compiler/common-operator-unittest.cc View 3 chunks +106 lines, -10 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/operator.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/compiler/operator.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M src/compiler/operator-properties-inl.h View 1 chunk +1 line, -1 line 2 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL
6 years, 3 months ago (2014-09-12 11:06:09 UTC) #2
Michael Starzinger
LGTM, just one comment. https://codereview.chromium.org/565753004/diff/40001/src/compiler/operator-properties-inl.h File src/compiler/operator-properties-inl.h (right): https://codereview.chromium.org/565753004/diff/40001/src/compiler/operator-properties-inl.h#newcode118 src/compiler/operator-properties-inl.h:118: return OpParameter<int>(op); This is scarily ...
6 years, 3 months ago (2014-09-12 11:47:02 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/565753004/diff/40001/src/compiler/operator-properties-inl.h File src/compiler/operator-properties-inl.h (right): https://codereview.chromium.org/565753004/diff/40001/src/compiler/operator-properties-inl.h#newcode118 src/compiler/operator-properties-inl.h:118: return OpParameter<int>(op); On 2014/09/12 11:47:02, Michael Starzinger wrote: > ...
6 years, 3 months ago (2014-09-12 11:59:08 UTC) #4
Benedikt Meurer
6 years, 3 months ago (2014-09-12 11:59:42 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 23913 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698