src/compiler/operator-properties-inl.h - Issue 565753004: [turbofan] Some common operators are globally shared singletons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/operator-properties-inl.h

Issue 565753004: [turbofan] Some common operators are globally shared singletons. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fixes2 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/operator-properties-inl.h

diff --git a/src/compiler/operator-properties-inl.h b/src/compiler/operator-properties-inl.h

index 40534f7586b86563d8f0066eb62068d2ab4a6f25..0d5a403db76012cc6cc860308a690fd19652a31e 100644

--- a/src/compiler/operator-properties-inl.h

+++ b/src/compiler/operator-properties-inl.h

@@ -115,7 +115,7 @@ inline int OperatorProperties::GetControlInputCount(const Operator* op) {

#define OPCODE_CASE(x) case IrOpcode::k##x:

CONTROL_OP_LIST(OPCODE_CASE)

#undef OPCODE_CASE

- return static_cast<const ControlOperator*>(op)->ControlInputCount();

+ return OpParameter<int>(op);

Michael Starzinger 2014/09/12 11:47:02 This is scarily implicit, can we leave a comment h

Benedikt Meurer 2014/09/12 11:59:08 Done.

default:

// Operators that have write effects must have a control

// dependency. Effect dependencies only ensure the correct order of

« no previous file with comments | « src/compiler/operator.cc ('k') | src/compiler/raw-machine-assembler.h » ('j') | no next file with comments »