Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

Issue 565673002: Close the password bubble when navigating between tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove debug code Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
index e651c2c2587377f32713445b95a941f07b8aa239..2c0d3f07fffcb5e18423004c24a459485410423b 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
@@ -17,7 +17,6 @@ ManagePasswordsIconView::ManagePasswordsIconView(CommandUpdater* updater)
: BubbleIconView(updater, IDC_MANAGE_PASSWORDS_FOR_PAGE) {
set_id(VIEW_ID_MANAGE_PASSWORDS_ICON_BUTTON);
SetFocusable(true);
- UpdateVisibleUI();
Mike West 2014/09/12 11:03:50 Did this call cause problems?
vasilii 2014/09/12 12:29:58 No, but it doesn't belong here. Setting visibility
}
ManagePasswordsIconView::~ManagePasswordsIconView() {}
@@ -30,6 +29,7 @@ void ManagePasswordsIconView::UpdateVisibleUI() {
return;
}
+ ManagePasswordsBubbleView::CloseBubbleForInactiveTab();
Mike West 2014/09/12 11:03:50 This seems a bit roundabout, and platform-specific
dconnelly 2014/09/12 11:15:26 This bug doesn't appear on Mac (https://code.googl
vasilii 2014/09/12 12:29:58 Mike, to make it cross platform we need cross plat
dconnelly 2014/09/12 12:31:41 This would be pretty straightforward to add to the
SetVisible(true);
SetImage(ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(icon_id_));
SetTooltipText(l10n_util::GetStringUTF16(tooltip_text_id_));

Powered by Google App Engine
This is Rietveld 408576698