Close the password bubble when navigating between tabs.

chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

Index: chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
index e651c2c2587377f32713445b95a941f07b8aa239..2c0d3f07fffcb5e18423004c24a459485410423b 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
@@ -17,7 +17,6 @@ ManagePasswordsIconView::ManagePasswordsIconView(CommandUpdater* updater)
     : BubbleIconView(updater, IDC_MANAGE_PASSWORDS_FOR_PAGE) {
   set_id(VIEW_ID_MANAGE_PASSWORDS_ICON_BUTTON);
   SetFocusable(true);
-  UpdateVisibleUI();

[Mike West, 2014/09/12 11:03:50]

Did this call cause problems?

[vasilii, 2014/09/12 12:29:58]

No, but it doesn't belong here. Setting visibility and calling layout are not
right things for the constructor.

 }
 
 ManagePasswordsIconView::~ManagePasswordsIconView() {}
@@ -30,6 +29,7 @@ void ManagePasswordsIconView::UpdateVisibleUI() {
     return;
   }
 
+  ManagePasswordsBubbleView::CloseBubbleForInactiveTab();

[Mike West, 2014/09/12 11:03:50]

This seems a bit roundabout, and platform-specific. ManagePasswordsUIController
is a WebContentsObserver. Could you instead override
WebContentsObserver::WasHidden in order to drive this behavior? This has the
advantage of forcing you to do something in the platform-agnostic bits that
Daniel could hook into for Mac.

[dconnelly, 2014/09/12 11:15:26]

This bug doesn't appear on Mac
(https://code.google.com/p/chromium/issues/detail?id=412247#c2), so I'm not that
worried. Of course, if it simplifies other logic or prevents Mac bugs in the
future I'm all for it :)

[vasilii, 2014/09/12 12:29:58]

Mike, to make it cross platform we need cross platform methods CloseBubble() and
IsShowing(). We don't have them now.

[dconnelly, 2014/09/12 12:31:41]

This would be pretty straightforward to add to the cross-platform bubble
interface, though.

   SetVisible(true);
   SetImage(ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(icon_id_));
   SetTooltipText(l10n_util::GetStringUTF16(tooltip_text_id_));