Close the password bubble when navigating between tabs.

chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h"
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/command_updater.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 #include "chrome/browser/ui/view_ids.h"
 #include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
 #include "components/password_manager/core/common/password_manager_ui.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 ManagePasswordsIconView::ManagePasswordsIconView(CommandUpdater* updater)
     : BubbleIconView(updater, IDC_MANAGE_PASSWORDS_FOR_PAGE) {
   set_id(VIEW_ID_MANAGE_PASSWORDS_ICON_BUTTON);
   SetFocusable(true);
-  UpdateVisibleUI();

[Mike West, 2014/09/12 11:03:50]

Did this call cause problems?

[vasilii, 2014/09/12 12:29:58]

No, but it doesn't belong here. Setting visibility and calling layout are not
right things for the constructor.

 }
 
 ManagePasswordsIconView::~ManagePasswordsIconView() {}
 
 void ManagePasswordsIconView::UpdateVisibleUI() {
   if (state() == password_manager::ui::INACTIVE_STATE) {
     SetVisible(false);
     if (ManagePasswordsBubbleView::IsShowing())
       ManagePasswordsBubbleView::CloseBubble();
     return;
   }
 
+  ManagePasswordsBubbleView::CloseBubbleForInactiveTab();

[Mike West, 2014/09/12 11:03:50]

This seems a bit roundabout, and platform-specific. ManagePasswordsUIController
is a WebContentsObserver. Could you instead override
WebContentsObserver::WasHidden in order to drive this behavior? This has the
advantage of forcing you to do something in the platform-agnostic bits that
Daniel could hook into for Mac.

[dconnelly, 2014/09/12 11:15:26]

This bug doesn't appear on Mac
(https://code.google.com/p/chromium/issues/detail?id=412247#c2), so I'm not that
worried. Of course, if it simplifies other logic or prevents Mac bugs in the
future I'm all for it :)

[vasilii, 2014/09/12 12:29:58]

Mike, to make it cross platform we need cross platform methods CloseBubble() and
IsShowing(). We don't have them now.

[dconnelly, 2014/09/12 12:31:41]

This would be pretty straightforward to add to the cross-platform bubble
interface, though.

   SetVisible(true);
   SetImage(ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(icon_id_));
   SetTooltipText(l10n_util::GetStringUTF16(tooltip_text_id_));
 
   // We may be about to automatically pop up a ManagePasswordsBubbleView.
   // Force layout of the icon's parent now; the bubble will be incorrectly
   // positioned otherwise, as the icon won't have been drawn into position.
   parent()->Layout();
 }
 
@@ skipping 26 matching lines @@
     return true;
   }
   return BubbleIconView::OnKeyPressed(event);
 }
 
 void ManagePasswordsIconView::AboutToRequestFocusFromTabTraversal(
     bool reverse) {
   if (active())
     ManagePasswordsBubbleView::ActivateBubble();
 }