chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h - Issue 565673002: Close the password bubble when navigating between tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

Issue 565673002: Close the password bubble when navigating between tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove debug code Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_icon.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc » ('j') | chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

index 96af180d8167db3c586792efe76d3abc731c62ef..a0f7fc05460460cf876c79fec5bdadf06f11f48b 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

@@ -32,6 +32,9 @@ class ManagePasswordsBubbleView : public ManagePasswordsBubble,

// Closes the existing bubble.

static void CloseBubble();

+ // Closes the bubble if it's current tab isn't active.

+ static void CloseBubbleForInactiveTab();

Mike West 2014/09/12 11:03:50 Nit: How about 'CloseBubbleIfTabIsInactive()'.

vasilii 2014/09/12 12:29:58 Done.

// Makes the bubble the foreground window.

static void ActivateBubble();