Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3082)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 565673002: Close the password bubble when navigating between tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove debug code Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index b6e70f74144b786d8f2a5632a7153aea9a18c8fd..882b6237a8b354b6f2aa7c6334e45283cb2c7869 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
#include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
#include "chrome/browser/ui/passwords/save_password_refusal_combobox_model.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
#include "chrome/browser/ui/views/passwords/manage_password_item_view.h"
@@ -758,6 +759,17 @@ void ManagePasswordsBubbleView::CloseBubble() {
}
// static
+void ManagePasswordsBubbleView::CloseBubbleForInactiveTab() {
+ if (!IsShowing())
+ return;
+ content::WebContents* web_contents =
+ manage_passwords_bubble_->model()->web_contents();
+ Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
+ if (web_contents != browser->tab_strip_model()->GetActiveWebContents())
+ CloseBubble();
+}
+
+// static
void ManagePasswordsBubbleView::ActivateBubble() {
if (!IsShowing())
return;

Powered by Google App Engine
This is Rietveld 408576698