Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1966)

Unified Diff: Source/platform/audio/AudioUtilities.h

Issue 565643003: Move utility functions for sample rate to AudioUtilities. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/audio/AudioUtilities.h
diff --git a/Source/platform/audio/AudioUtilities.h b/Source/platform/audio/AudioUtilities.h
index a7e02d721f2435224c4081f2ff9c4f8a9b55992c..d26d01498af4846af70464f923e9abb8c6247473 100644
--- a/Source/platform/audio/AudioUtilities.h
+++ b/Source/platform/audio/AudioUtilities.h
@@ -42,6 +42,15 @@ PLATFORM_EXPORT double discreteTimeConstantForSampleRate(double timeConstant, do
// Convert the time to a sample frame at the given sample rate.
PLATFORM_EXPORT size_t timeToSampleFrame(double time, double sampleRate);
+// Check the given sample rate is supported by platform.
Raymond Toy 2014/09/11 16:38:45 Be more descriptive. Something like // Check that
KhNo 2014/09/12 15:01:05 Done.
+PLATFORM_EXPORT bool isSampleRateRangeGood(float sampleRate);
Raymond Toy 2014/09/11 16:38:45 Maybe a better name would be isValidAudioBufferSam
KhNo 2014/09/12 15:01:05 Yes, it is for AudioBuffer. I have done.
+
+// Caculates correct fftsize with the given sample rate.
Raymond Toy 2014/09/11 16:38:45 Fix typo: Caculates -> Calculates. And make it cl
KhNo 2014/09/12 15:01:05 I think you right. There is better position. I rev
+PLATFORM_EXPORT size_t fftSizeForSampleRate(float sampleRate);
+
+// Renturn max/min sample rate that platform supported.
Raymond Toy 2014/09/11 16:38:45 Fix typo: Renturn -> Return. And as for isSampleR
KhNo 2014/09/12 15:01:05 Done.
+PLATFORM_EXPORT float minAllowedSampleRate();
+PLATFORM_EXPORT float maxAllowedSampleRate();
Raymond Toy 2014/09/11 16:38:45 Maybe rename these to minAudioBufferSampleRate and
KhNo 2014/09/12 15:01:05 Done.
} // AudioUtilites
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698