Source/platform/audio/AudioUtilities.h - Issue 565643003: Move utility functions for sample rate to AudioUtilities.

Side by Side Diff: Source/platform/audio/AudioUtilities.h

Issue 565643003: Move utility functions for sample rate to AudioUtilities. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010, Google Inc. All rights reserved.	2 * Copyright (C) 2010, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 24 matching lines...) Expand all Loading...
35 PLATFORM_EXPORT float decibelsToLinear(float);	35 PLATFORM_EXPORT float decibelsToLinear(float);

36	36

37 // timeConstant is the time it takes a first-order linear time-invariant system	37 // timeConstant is the time it takes a first-order linear time-invariant system

38 // to reach the value 1 - 1/e (around 63.2%) given a step input response.	38 // to reach the value 1 - 1/e (around 63.2%) given a step input response.

39 // discreteTimeConstantForSampleRate() will return the discrete time-constant fo r the specific sampleRate.	39 // discreteTimeConstantForSampleRate() will return the discrete time-constant fo r the specific sampleRate.

40 PLATFORM_EXPORT double discreteTimeConstantForSampleRate(double timeConstant, do uble sampleRate);	40 PLATFORM_EXPORT double discreteTimeConstantForSampleRate(double timeConstant, do uble sampleRate);

41	41

42 // Convert the time to a sample frame at the given sample rate.	42 // Convert the time to a sample frame at the given sample rate.

43 PLATFORM_EXPORT size_t timeToSampleFrame(double time, double sampleRate);	43 PLATFORM_EXPORT size_t timeToSampleFrame(double time, double sampleRate);

44	44

	45 // Check the given sample rate is supported by platform.
	Raymond Toy 2014/09/11 16:38:45 Be more descriptive. Something like // Check that Be more descriptive. Something like // Check that \|sampleRate\| is a valid rate for AudioBuffers. KhNo 2014/09/12 15:01:05 Done. Show quoted text On 2014/09/11 16:38:45, Raymond Toy wrote: > Be more descriptive. Something like > > // Check that \|sampleRate\| is a valid rate for AudioBuffers. Done.
	46 PLATFORM_EXPORT bool isSampleRateRangeGood(float sampleRate);
	Raymond Toy 2014/09/11 16:38:45 Maybe a better name would be isValidAudioBufferSam Maybe a better name would be isValidAudioBufferSampleRate? KhNo 2014/09/12 15:01:05 Yes, it is for AudioBuffer. I have done. Show quoted text On 2014/09/11 16:38:45, Raymond Toy wrote: > Maybe a better name would be isValidAudioBufferSampleRate? Yes, it is for AudioBuffer. I have done.
	47

	48 // Caculates correct fftsize with the given sample rate.
	Raymond Toy 2014/09/11 16:38:45 Fix typo: Caculates -> Calculates. And make it cl Fix typo: Caculates -> Calculates. And make it clear this is for the HRTF Panner, not just any old fft size. And maybe rename it to hrtfFFTSizeForSampleRate to make it clearer. Actually, I think it might be better to leave fftSizeForSampleRate in HRTFPanner instead of moving it here. It's really specific to the panner. KhNo 2014/09/12 15:01:05 I think you right. There is better position. I rev Show quoted text On 2014/09/11 16:38:45, Raymond Toy wrote: > Fix typo: Caculates -> Calculates. > > And make it clear this is for the HRTF Panner, not just any old fft size. > > And maybe rename it to hrtfFFTSizeForSampleRate to make it clearer. > > Actually, I think it might be better to leave fftSizeForSampleRate in HRTFPanner > instead of moving it here. It's really specific to the panner. I think you right. There is better position. I reverted it.
	49 PLATFORM_EXPORT size_t fftSizeForSampleRate(float sampleRate);

	50

	51 // Renturn max/min sample rate that platform supported.
	Raymond Toy 2014/09/11 16:38:45 Fix typo: Renturn -> Return. And as for isSampleR Fix typo: Renturn -> Return. And as for isSampleRateRangeGood, state this is for AudioBuffers KhNo 2014/09/12 15:01:05 Done. Show quoted text On 2014/09/11 16:38:45, Raymond Toy wrote: > Fix typo: Renturn -> Return. > > And as for isSampleRateRangeGood, state this is for AudioBuffers Done.
	52 PLATFORM_EXPORT float minAllowedSampleRate();

	53 PLATFORM_EXPORT float maxAllowedSampleRate();
	Raymond Toy 2014/09/11 16:38:45 Maybe rename these to minAudioBufferSampleRate and Maybe rename these to minAudioBufferSampleRate and maxAudioBufferSampleRate? KhNo 2014/09/12 15:01:05 Done. Show quoted text On 2014/09/11 16:38:45, Raymond Toy wrote: > Maybe rename these to minAudioBufferSampleRate and maxAudioBufferSampleRate? Done.
45 } // AudioUtilites	54 } // AudioUtilites

46 } // namespace blink	55 } // namespace blink

47	56

48 #endif // AudioUtilities_h	57 #endif // AudioUtilities_h

OLD	NEW

« no previous file with comments | « Source/modules/webaudio/OfflineAudioContext.cpp ('k') | Source/platform/audio/AudioUtilities.cpp » ('j') | Source/platform/audio/AudioUtilities.cpp » ('J')