Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 565613002: Remove usages of temporary Range objects that end up registered on the (Closed)

Created:
6 years, 3 months ago by Mads Ager (chromium)
Modified:
6 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, groby+blinkspell_chromium.org, rwlbuis, yoichio
Project:
blink
Visibility:
Public.

Description

Remove usages of temporary Range objects that end up registered on the Document for no reason. This is important for Oilpan because the Ranges do not die until the next GC. This gives a 10% improvement on DOM/textarea-edit in the oilpan build. R=yosin@chromium.org BUG=388681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -38 lines) Patch
M Source/core/dom/DocumentMarkerController.h View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/core/dom/DocumentMarkerController.cpp View 2 chunks +14 lines, -2 lines 0 comments Download
M Source/core/editing/SpellChecker.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M Source/core/editing/TextIterator.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 2 chunks +50 lines, -0 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 3 chunks +23 lines, -18 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 6 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mads Ager (chromium)
6 years, 3 months ago (2014-09-11 10:30:37 UTC) #1
yosin_UTC9
LGTM yoicho@, just FYI, removing document markers, by spell checker, also causes layout update via ...
6 years, 3 months ago (2014-09-12 01:07:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565613002/1
6 years, 3 months ago (2014-09-12 09:21:05 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 10:24:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181889

Powered by Google App Engine
This is Rietveld 408576698