Remove usages of temporary Range objects that end up registered on the

Source/core/editing/VisibleSelection.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 186 matching lines @@
     if (isNone())
         return false;
     Position start = m_start.parentAnchoredEquivalent();
     Position end = m_end.parentAnchoredEquivalent();
     TrackExceptionState exceptionState;
     return Range::intersectsNode(node, start, end, exceptionState) && !exceptionState.hadException();
 }
 
 PassRefPtrWillBeRawPtr<Range> VisibleSelection::toNormalizedRange() const
 {
+    Position start, end;
+    if (toNormalizedPositions(start, end))
+        return Range::create(*start.document(), start, end);
+    return nullptr;
+}
+
+bool VisibleSelection::toNormalizedPositions(Position& start, Position& end) const
+{
     if (isNone())
-        return nullptr;
+        return false;
 
     // Make sure we have an updated layout since this function is called
     // in the course of running edit commands which modify the DOM.
     // Failing to call this can result in equivalentXXXPosition calls returning
     // incorrect results.
     m_start.document()->updateLayout();
 
     // Check again, because updating layout can clear the selection.
     if (isNone())
-        return nullptr;
+        return false;
 
-    Position s, e;
     if (isCaret()) {
         // If the selection is a caret, move the range start upstream. This helps us match
         // the conventions of text editors tested, which make style determinations based
         // on the character before the caret, if any.
-        s = m_start.upstream().parentAnchoredEquivalent();
-        e = s;
+        start = m_start.upstream().parentAnchoredEquivalent();
+        end = start;
     } else {
         // If the selection is a range, select the minimum range that encompasses the selection.
         // Again, this is to match the conventions of text editors tested, which make style
         // determinations based on the first character of the selection.
         // For instance, this operation helps to make sure that the "X" selected below is the
         // only thing selected. The range should not be allowed to "leak" out to the end of the
         // previous text node, or to the beginning of the next text node, each of which has a
         // different style.
         //
         // On a treasure map, <b>X</b> marks the spot.
         //                       ^ selected
         //
         ASSERT(isRange());
-        s = m_start.downstream();
-        e = m_end.upstream();
-        if (comparePositions(s, e) > 0) {
+        start = m_start.downstream();
+        end = m_end.upstream();
+        if (comparePositions(start, end) > 0) {
             // Make sure the start is before the end.
             // The end can wind up before the start if collapsed whitespace is the only thing selected.
-            Position tmp = s;
-            s = e;
-            e = tmp;
+            Position tmp = start;
+            start = end;
+            end = tmp;
         }
-        s = s.parentAnchoredEquivalent();
-        e = e.parentAnchoredEquivalent();
+        start = start.parentAnchoredEquivalent();
+        end = end.parentAnchoredEquivalent();
     }
 
-    if (!s.containerNode() || !e.containerNode())
-        return nullptr;
+    if (!start.containerNode() || !end.containerNode())
+        return false;
 
-    // VisibleSelections are supposed to always be valid.  This constructor will ASSERT
-    // if a valid range could not be created, which is fine for this callsite.
-    return Range::create(*s.document(), s, e);
+    return true;
 }
 
 bool VisibleSelection::expandUsingGranularity(TextGranularity granularity)
 {
     if (isNone())
         return false;
 
     // FIXME: Do we need to check all of them?
     Position oldBase = m_base;
     Position oldExtent = m_extent;
@@ skipping 597 matching lines @@
     sel.showTreeForThis();
 }
 
 void showTree(const blink::VisibleSelection* sel)
 {
     if (sel)
         sel->showTreeForThis();
 }
 
 #endif