Fix typed lowering of ToBoolean on NaN input.

Fix typed lowering of ToBoolean on NaN input.

R=rossberg@chromium.org
TEST=webkit/convert-nan-to-bool

Committed: https://code.google.com/p/v8/source/detail?r=23875

[Michael Starzinger, 2014-09-11 12:05:14]

https://codereview.chromium.org/565493003/diff/1/src/types.h
File src/types.h (right):

https://codereview.chromium.org/565493003/diff/1/src/types.h#newcode190
src/types.h:190: V(Internal,            1 << 21 | REPRESENTATION(kTagged |
kUntagged)) \
Please appreciate me not clang-formatting this macro. I couldn't figure out how
to annotate it so that clang-format leaves it untouched though.

[rossberg, 2014-09-11 12:17:50]

LGTM

https://codereview.chromium.org/565493003/diff/1/src/compiler/js-typed-loweri...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/565493003/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:476: return Changed(input);  //
JSToBoolean(boolean) => x
s/x/boolean/

https://codereview.chromium.org/565493003/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:495: // JSToBoolean(ordered-number) =>
BooleanNot(NumberEqual(x, #0))
s/x/ordered-number/

https://codereview.chromium.org/565493003/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:632: // JSUnaryNot(boolean) => BooleanNot(x)
s/x/boolean/

https://codereview.chromium.org/565493003/diff/1/src/types.h
File src/types.h (right):

https://codereview.chromium.org/565493003/diff/1/src/types.h#newcode190
src/types.h:190: V(Internal,            1 << 21 | REPRESENTATION(kTagged |
kUntagged)) \
On 2014/09/11 12:05:14, Michael Starzinger wrote:
> Please appreciate me not clang-formatting this macro. I couldn't figure out
how
> to annotate it so that clang-format leaves it untouched though.

Acknowledged.

[Michael Starzinger, 2014-09-11 12:35:59]

Addressed comments. Landing.

https://codereview.chromium.org/565493003/diff/1/src/compiler/js-typed-loweri...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/565493003/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:476: return Changed(input);  //
JSToBoolean(boolean) => x
On 2014/09/11 12:17:50, rossberg wrote:
> s/x/boolean/

Done, but with a slightly different notation as per offline discussion.

https://codereview.chromium.org/565493003/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:495: // JSToBoolean(ordered-number) =>
BooleanNot(NumberEqual(x, #0))
On 2014/09/11 12:17:50, rossberg wrote:
> s/x/ordered-number/

Done.

https://codereview.chromium.org/565493003/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:632: // JSUnaryNot(boolean) => BooleanNot(x)
On 2014/09/11 12:17:50, rossberg wrote:
> s/x/boolean/

Done.

[Michael Starzinger, 2014-09-11 12:38:27]

Committed patchset #2 (id:20001) manually as 23875 (presubmit successful).