Fix typed lowering of ToBoolean on NaN input.

src/types.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_TYPES_H_
 #define V8_TYPES_H_
 
 #include "src/factory.h"
 #include "src/handles.h"
 #include "src/ostreams.h"
@@ skipping 169 matching lines @@
   V(Symbol,              1 << 11 | REPRESENTATION(kTaggedPtr)) \
   V(InternalizedString,  1 << 12 | REPRESENTATION(kTaggedPtr)) \
   V(OtherString,         1 << 13 | REPRESENTATION(kTaggedPtr)) \
   V(Undetectable,        1 << 14 | REPRESENTATION(kTaggedPtr)) \
   V(Array,               1 << 15 | REPRESENTATION(kTaggedPtr)) \
   V(Buffer,              1 << 16 | REPRESENTATION(kTaggedPtr)) \
   V(Function,            1 << 17 | REPRESENTATION(kTaggedPtr)) \
   V(RegExp,              1 << 18 | REPRESENTATION(kTaggedPtr)) \
   V(OtherObject,         1 << 19 | REPRESENTATION(kTaggedPtr)) \
   V(Proxy,               1 << 20 | REPRESENTATION(kTaggedPtr)) \
   V(Internal,            1 << 21 | REPRESENTATION(kTagged | kUntagged)) \

[Michael Starzinger, 2014/09/11 12:05:14]

Please appreciate me not clang-formatting this macro. I couldn't figure out how
to annotate it so that clang-format leaves it untouched though.

[rossberg, 2014/09/11 12:17:50]

Acknowledged.

   \
   V(SignedSmall,         kUnsignedSmall | kOtherSignedSmall) \
   V(Signed32,            kSignedSmall | kOtherUnsigned31 | kOtherSigned32) \
   V(Unsigned32,          kUnsignedSmall | kOtherUnsigned31 | kOtherUnsigned32) \
   V(Integral32,          kSigned32 | kUnsigned32) \
-  V(Number,              kIntegral32 | kMinusZero | kNaN | kOtherNumber) \
+  V(OrderedNumber,       kIntegral32 | kMinusZero | kOtherNumber) \
+  V(Number,              kOrderedNumber | kNaN) \
   V(String,              kInternalizedString | kOtherString) \
   V(UniqueName,          kSymbol | kInternalizedString) \
   V(Name,                kSymbol | kString) \
   V(NumberOrString,      kNumber | kString) \
   V(Primitive,           kNumber | kName | kBoolean | kNull | kUndefined) \
   V(DetectableObject,    kArray | kFunction | kRegExp | kOtherObject) \
   V(DetectableReceiver,  kDetectableObject | kProxy) \
   V(Detectable,          kDetectableReceiver | kNumber | kName) \
   V(Object,              kDetectableObject | kUndetectable) \
   V(Receiver,            kObject | kProxy) \
@@ skipping 788 matching lines @@
   bool Narrows(BoundsImpl that) {
     return that.lower->Is(this->lower) && this->upper->Is(that.upper);
   }
 };
 
 typedef BoundsImpl<ZoneTypeConfig> Bounds;
 
 } }  // namespace v8::internal
 
 #endif  // V8_TYPES_H_