Issue 565493002: Use invalidation set for :empty pseudo changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 565493002: Use invalidation set for :empty pseudo changes. (Closed)

Created:
6 years, 3 months ago by rune

Modified:
6 years, 3 months ago

Reviewers:
chrishtr, esprehn

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, rune+blink, sof

Base URL:
https://chromium.googlesource.com/chromium/blink.git@empty-flag-20140910

Project:
blink

Visibility:
Public.

More Reviews

Description

Use invalidation set for :empty pseudo changes. Schedule an invalidation set for :empty on an element when the pseudo state changes instead of a SubtreeStyleChange. R=chrishtr@chromium.org,esprehn@chromium.org BUG=412999 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181805

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -4 lines)			Patch
A	LayoutTests/fast/css/invalidation/empty-pseudo.html	View	1 chunk	+46 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css/invalidation/empty-pseudo-expected.txt	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css/invalidation/empty-pseudo-sibling.html	View	1 chunk	+45 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css/invalidation/empty-pseudo-sibling-expected.txt	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	Source/core/css/RuleFeature.cpp	View	1 chunk	+9 lines, -3 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rune

Depends on [1] for passing the sibling tests. [1] https://codereview.chromium.org/558333002

6 years, 3 months ago (2014-09-10 22:37:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565493002/1

6 years, 3 months ago (2014-09-11 07:39:00 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-11 08:46:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 181805

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages