Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 565493002: Use invalidation set for :empty pseudo changes. (Closed)

Created:
6 years, 3 months ago by rune
Modified:
6 years, 3 months ago
Reviewers:
chrishtr, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, rune+blink, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@empty-flag-20140910
Project:
blink
Visibility:
Public.

Description

Use invalidation set for :empty pseudo changes. Schedule an invalidation set for :empty on an element when the pseudo state changes instead of a SubtreeStyleChange. R=chrishtr@chromium.org,esprehn@chromium.org BUG=412999 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -4 lines) Patch
A LayoutTests/fast/css/invalidation/empty-pseudo.html View 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/empty-pseudo-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/empty-pseudo-sibling.html View 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/empty-pseudo-sibling-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +9 lines, -3 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
rune
Depends on [1] for passing the sibling tests. [1] https://codereview.chromium.org/558333002
6 years, 3 months ago (2014-09-10 22:37:39 UTC) #1
esprehn
lgtm, seems reasonable.
6 years, 3 months ago (2014-09-11 01:00:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565493002/1
6 years, 3 months ago (2014-09-11 07:39:00 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 08:46:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181805

Powered by Google App Engine
This is Rietveld 408576698