Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 558333002: Don't clear StyleAffectedByEmpty before recalc. (Closed)

Created:
6 years, 3 months ago by rune
Modified:
6 years, 3 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Don't clear StyleAffectedByEmpty before recalc. ElementRareData::resetStyleState() cleared the StyleAffectedByEmpty flag before recalculating style for an Element. However, this flag can be set by style recalc for any of the sibling subtree elements in the presence of adjacent combinators. If you have a LocalStyleChange for the element that may become empty/non-empty, the flag can not be cleared since it may never be set again unless the siblings affected by the :empty state are recalculated. R=esprehn@chromium.org BUG=412950 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -15 lines) Patch
A LayoutTests/fast/css/pseudo-empty-adjacent-dynamic.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/pseudo-empty-adjacent-dynamic-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/pseudo-not-empty-adjacent-dynamic.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/pseudo-not-empty-adjacent-dynamic-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +2 lines, -8 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rune
6 years, 3 months ago (2014-09-10 22:35:16 UTC) #1
esprehn
Hmm, this means that nothing will ever clear this flag so once you're affected by ...
6 years, 3 months ago (2014-09-11 00:56:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558333002/1
6 years, 3 months ago (2014-09-11 06:25:45 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 07:30:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181799

Powered by Google App Engine
This is Rietveld 408576698