Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 565433002: Fix incorrect touch transform before gesture recognition. (Closed)

Created:
6 years, 3 months ago by tdresser
Modified:
6 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect touch transform before gesture recognition. TEST=see crbug.com/412875 BUG=412749 Committed: https://crrev.com/b6387c5f9a80afa222b246c0aa0d04e989acf89c Cr-Commit-Position: refs/heads/master@{#294220}

Patch Set 1 #

Patch Set 2 : Don't transform the touch event at all. #

Patch Set 3 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M ui/aura/window_event_dispatcher.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/window_event_dispatcher.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tdresser
6 years, 3 months ago (2014-09-10 18:31:24 UTC) #2
tdresser
6 years, 3 months ago (2014-09-10 18:51:50 UTC) #3
sadrul
Can you update the comment for ProcessedTouchEvent() in window_event_dispatcher.h that the event should be in ...
6 years, 3 months ago (2014-09-10 18:53:34 UTC) #4
tdresser
6 years, 3 months ago (2014-09-10 18:55:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/565433002/40001
6 years, 3 months ago (2014-09-10 19:05:06 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 03e72098415d8a5f2ce541861d6ddbeb8956ffe3
6 years, 3 months ago (2014-09-10 20:43:42 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 20:46:19 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b6387c5f9a80afa222b246c0aa0d04e989acf89c
Cr-Commit-Position: refs/heads/master@{#294220}

Powered by Google App Engine
This is Rietveld 408576698