Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 565423003: Move extensions manifest tests to run in extensions_unittests (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move extensions manifest tests to run in extensions_unittests They don't need to run in Chrome's unit_tests suite. * Move FileHandlersManifestTest * Move ExternallyConnectableManifestTest * Migrate some _manifest_features.json entries that should have been under src/extensions a while ago. BUG=397165 TEST=extensions_unittests, unit_tests Committed: https://crrev.com/a02b3e5b8ea70a6f362ef804ee552255b40a2c74 Cr-Commit-Position: refs/heads/master@{#295479}

Patch Set 1 #

Total comments: 1

Patch Set 2 : (manifest2) fix deps, android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -629 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 5 chunks +0 lines, -51 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_all_ids.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_bad_id.json View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_error_all_urls.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_error_bad_matches.json View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_error_effective_tld.json View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_error_tld.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_error_unknown_tld.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_error_wildcard_host.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_error_wrong_format.json View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_ids.json View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_ids_and_matches.json View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_matches.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_matches_tls_channel_id.json View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/externally_connectable_nothing_specified.json View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/file_handlers_invalid_extension.json View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/file_handlers_invalid_extension_element.json View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/file_handlers_invalid_handlers.json View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/file_handlers_invalid_no_type_or_extension.json View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/file_handlers_invalid_not_app.json View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/file_handlers_invalid_too_many.json View 1 chunk +0 lines, -226 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/file_handlers_invalid_type.json View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/file_handlers_invalid_type_element.json View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/file_handlers_valid.json View 1 chunk +0 lines, -26 lines 0 comments Download
M extensions/DEPS View 1 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/common/api/_manifest_features.json View 3 chunks +52 lines, -0 lines 0 comments Download
M extensions/common/common_manifest_handlers.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download
M extensions/common/manifest_handlers/externally_connectable_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/common/manifest_handlers/file_handler_manifest_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M extensions/common/permissions/extensions_api_permissions.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/extensions_strings.grd View 1 chunk +4 lines, -0 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_all_ids.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_bad_id.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_error_all_urls.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_error_bad_matches.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_error_effective_tld.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_error_tld.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_error_unknown_tld.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_error_wildcard_host.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_error_wrong_format.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_ids.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_ids_and_matches.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_matches.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_matches_tls_channel_id.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/externally_connectable_nothing_specified.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/file_handlers_invalid_extension.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/file_handlers_invalid_extension_element.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/file_handlers_invalid_handlers.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/file_handlers_invalid_no_type_or_extension.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/file_handlers_invalid_not_app.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/file_handlers_invalid_too_many.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/file_handlers_invalid_type.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/file_handlers_invalid_type_element.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/file_handlers_valid.json View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
James Cook
yoz, PTAL I'm working on another CL that removes the last tests. It's dependent on ...
6 years, 3 months ago (2014-09-17 18:14:24 UTC) #2
James Cook
To rockot, since yoz is OOO today
6 years, 3 months ago (2014-09-17 21:46:04 UTC) #4
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/565423003/diff/1/chrome/common/extensions/api/_manifest_features.json File chrome/common/extensions/api/_manifest_features.json (left): https://codereview.chromium.org/565423003/diff/1/chrome/common/extensions/api/_manifest_features.json#oldcode273 chrome/common/extensions/api/_manifest_features.json:273: "name": { Hah, this and version are particularly ...
6 years, 3 months ago (2014-09-17 22:12:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565423003/20001
6 years, 3 months ago (2014-09-17 22:20:06 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-18 00:21:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/565423003/20001
6 years, 3 months ago (2014-09-18 15:21:42 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as dfc6f77fbef115c8fd381da1be8fa442dfdddbdc
6 years, 3 months ago (2014-09-18 16:23:09 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 16:23:51 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a02b3e5b8ea70a6f362ef804ee552255b40a2c74
Cr-Commit-Position: refs/heads/master@{#295479}

Powered by Google App Engine
This is Rietveld 408576698