chrome/common/extensions/chrome_manifest_handlers.cc - Issue 565423003: Move extensions manifest tests to run in extensions_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/chrome_manifest_handlers.cc

Issue 565423003: Move extensions manifest tests to run in extensions_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: (manifest2) fix deps, android Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/_manifest_features.json ('k') | chrome/common/extensions/permissions/chrome_api_permissions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/chrome_manifest_handlers.cc

diff --git a/chrome/common/extensions/chrome_manifest_handlers.cc b/chrome/common/extensions/chrome_manifest_handlers.cc

index 93dd8d37f52e22dab42a0a1b5a7ec6528db5225d..44b8167cd4e01a4eddb5da0698b12b67023d7fe3 100644

--- a/chrome/common/extensions/chrome_manifest_handlers.cc

+++ b/chrome/common/extensions/chrome_manifest_handlers.cc

@@ -34,7 +34,6 @@

#include "chrome/common/extensions/manifest_url_handler.h"

#include "extensions/common/api/bluetooth/bluetooth_manifest_handler.h"

#include "extensions/common/api/sockets/sockets_manifest_handler.h"

-#include "extensions/common/manifest_handlers/externally_connectable.h"

#include "extensions/common/manifest_handlers/options_page_info.h"

#include "extensions/common/manifest_handlers/requirements_info.h"

@@ -53,7 +52,6 @@ void RegisterChromeManifestHandlers() {

(new ContentScriptsHandler)->Register();

(new DefaultLocaleHandler)->Register();

(new DevToolsPageHandler)->Register();

- (new ExternallyConnectableHandler)->Register();

(new FileBrowserHandlerParser)->Register();

(new HomepageURLHandler)->Register();

#if defined(OS_CHROMEOS)