Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 565103002: Revert of Do not create proxy hosts in the subtree of navigating frame. (Closed)

Created:
6 years, 3 months ago by engedy
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Do not create proxy hosts in the subtree of navigating frame. (patchset #11 id:200001 of https://codereview.chromium.org/536143002/) Reason for revert: SitePerProcessBrowserTest.ProxyCreationSkipsSubtree repeatedly fails on Mac with ASAN reporting use-after-free, see: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/2174 http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.8%20Buildrunner/builds/19009 @Nasko, as there are some simultaneous breakages right now, so I could not investigate this further and opted to revert the whole thing to get the tree green ASAP. Snippets from test log: ASSERTION FAILED: !localFrame || (localFrame->isLocalFrame()) ../../third_party/WebKit/Source/core/frame/LocalFrame.h(253) : blink::LocalFrame *blink::toLocalFrame(blink::Frame *) ../../content/browser/site_per_process_browsertest.cc:690: Failure Value of: child->child_count() Actual: 2 Expected: 0U Which is: 0 Original issue's description: > Do not create proxy hosts in the subtree of navigating frame. > > When a frame is navigating cross-process, its existing document will be completely destroyed and all child frames will be gone. This means that we don't need to create proxy objects for the new SiteInstance in the subtree of the navigating frame. > > BUG=357747 > > Committed: https://crrev.com/faab4288197b20b73610aad3e5579751b0c3a97b > Cr-Commit-Position: refs/heads/master@{#294520} TBR=ajwong@chromium.org,kenrb@chromium.org,jam@chromium.org,creis@chromium.org,dmazzoni@chromium.org,nasko@chromium.org NOTREECHECKS=true NOTRY=true BUG=357747 Committed: https://crrev.com/c328fa4adbb3dc43b921d643ac0cf73fea5c42ef Cr-Commit-Position: refs/heads/master@{#294552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -170 lines) Patch
M content/browser/accessibility/site_per_process_accessibility_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/frame_tree.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 3 chunks +7 lines, -15 lines 0 comments Download
M content/browser/frame_host/frame_tree_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 2 chunks +2 lines, -21 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 5 chunks +2 lines, -125 lines 0 comments Download
M content/test/data/site_per_process_main.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
engedy
Created Revert of Do not create proxy hosts in the subtree of navigating frame.
6 years, 3 months ago (2014-09-12 08:54:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565103002/1
6 years, 3 months ago (2014-09-12 08:55:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 66842583817ceedcfdb9e318277b56ad82540760
6 years, 3 months ago (2014-09-12 08:57:12 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 09:01:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c328fa4adbb3dc43b921d643ac0cf73fea5c42ef
Cr-Commit-Position: refs/heads/master@{#294552}

Powered by Google App Engine
This is Rietveld 408576698