cc: Remove the opaque rect return-parameter from ContentLayerClient.

cc: Remove the opaque rect return-parameter from ContentLayerClient.

This parameter is not used with impl-side painting, and blink is the
only embedder of blink that sets this value.

Since blink is always impl-side painting now, we can just remove it.

R=nduca, vmpstr
BUG=413479
Committed: https://crrev.com/9f825516164d5520a5c245ad247c395aeaca6caf
Cr-Commit-Position: refs/heads/master@{#294902}

[vmpstr, 2014-09-12 15:47:02]

Is Tile::opaque_rect being used still? If not, please also remove.

Is Layer/LayerImpl::contents_opaque being used? I think it might be since it's a
whole layer thing vs rect, but just to confirm.

[danakj, 2014-09-12 15:56:33]

On 2014/09/12 15:47:02, vmpstr wrote:
> Is Tile::opaque_rect being used still? If not, please also remove.

Nope, I thot I did woops.

> Is Layer/LayerImpl::contents_opaque being used? I think it might be since it's
a
> whole layer thing vs rect, but just to confirm.

Yes.

[danakj, 2014-09-12 15:57:24]

https://codereview.chromium.org/565043002/diff/1/cc/resources/layer_tiling_da...
File cc/resources/layer_tiling_data.h (left):

https://codereview.chromium.org/565043002/diff/1/cc/resources/layer_tiling_da...
cc/resources/layer_tiling_data.h:73: gfx::Rect opaque_rect_;
This is Tile::opaque_rect, is there another one I'm missing?

[vmpstr, 2014-09-12 15:58:40]

https://codereview.chromium.org/565043002/diff/1/cc/resources/layer_tiling_da...
File cc/resources/layer_tiling_data.h (left):

https://codereview.chromium.org/565043002/diff/1/cc/resources/layer_tiling_da...
cc/resources/layer_tiling_data.h:73: gfx::Rect opaque_rect_;
On 2014/09/12 15:57:24, danakj wrote:
> This is Tile::opaque_rect, is there another one I'm missing?

I mean cc/resources/tile.h

[danakj, 2014-09-12 16:04:22]

https://codereview.chromium.org/565043002/diff/1/cc/resources/layer_tiling_da...
File cc/resources/layer_tiling_data.h (left):

https://codereview.chromium.org/565043002/diff/1/cc/resources/layer_tiling_da...
cc/resources/layer_tiling_data.h:73: gfx::Rect opaque_rect_;
On 2014/09/12 15:58:40, vmpstr wrote:
> On 2014/09/12 15:57:24, danakj wrote:
> > This is Tile::opaque_rect, is there another one I'm missing?
> 
> I mean cc/resources/tile.h

Hm, thanks, didn't know that's there. But that's implside.. let me take a look
it might be different. Lunch first!

[danakj, 2014-09-12 16:57:12]

https://codereview.chromium.org/565043002/diff/1/cc/resources/layer_tiling_da...
File cc/resources/layer_tiling_data.h (left):

https://codereview.chromium.org/565043002/diff/1/cc/resources/layer_tiling_da...
cc/resources/layer_tiling_data.h:73: gfx::Rect opaque_rect_;
On 2014/09/12 16:04:22, danakj wrote:
> On 2014/09/12 15:58:40, vmpstr wrote:
> > On 2014/09/12 15:57:24, danakj wrote:
> > > This is Tile::opaque_rect, is there another one I'm missing?
> > 
> > I mean cc/resources/tile.h
> 
> Hm, thanks, didn't know that's there. But that's implside.. let me take a look
> it might be different. Lunch first!

Good call!! Removed!

[danakj, 2014-09-12 16:57:45]

Patchset #2 (id:20001) has been deleted

[vmpstr, 2014-09-12 17:21:30]

lgtm, thanks for doing this! (I'm not an owner in ui/compositor, but you are :P)

[danakj, 2014-09-12 21:35:10]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-09-12 21:35:15]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-09-15 18:53:10]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-09-15 18:53:24]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-09-15 19:29:38]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-09-15 19:34:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/565043002/60001

[danakj, 2014-09-15 20:07:18]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-09-15 20:09:44]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-09-15 20:11:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/565043002/80001

[commit-bot: I haz the power, 2014-09-15 20:40:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-15 20:40:24]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2014-09-15 20:45:37]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-09-15 20:46:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/565043002/100001

[commit-bot: I haz the power, 2014-09-15 22:27:13]

Committed patchset #5 (id:100001) as e9d835a708909f5d636e1b3e79c211e6e8ecd6c5

[commit-bot: I haz the power, 2014-09-15 22:35:12]

Patchset 5 (id:??) landed as
https://crrev.com/9f825516164d5520a5c245ad247c395aeaca6caf
Cr-Commit-Position: refs/heads/master@{#294902}