Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 565013003: Changing the order of initialization WeakPtrFactory (Closed)

Created:
6 years, 3 months ago by MRV
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
lgombos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changing the order of initialization WeakPtrFactory Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/6993ff96ffd1d66c38bcfbdc5c09c56a2c29330d Cr-Commit-Position: refs/heads/master@{#294567}

Patch Set 1 #

Patch Set 2 : Resolving the build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M content/gpu/gpu_watchdog_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/ipc_echo.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/shell/renderer/ipc_echo.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/accessibility_browser_test_utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/accessibility_browser_test_utils.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
MRV
PTAL
6 years, 3 months ago (2014-09-12 06:10:54 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 3 months ago (2014-09-12 06:15:21 UTC) #3
MRV
On 2014/09/12 06:15:21, Avi wrote: > lgtm Thanks Mr. Avi for LGTM
6 years, 3 months ago (2014-09-12 06:16:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565013003/20001
6 years, 3 months ago (2014-09-12 06:17:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 881bd9ca628df4843c4326412a428ee174c6b50f
6 years, 3 months ago (2014-09-12 09:53:39 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 09:59:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6993ff96ffd1d66c38bcfbdc5c09c56a2c29330d
Cr-Commit-Position: refs/heads/master@{#294567}

Powered by Google App Engine
This is Rietveld 408576698