content/shell/renderer/ipc_echo.cc - Issue 565013003: Changing the order of initialization WeakPtrFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/ipc_echo.cc

Issue 565013003: Changing the order of initialization WeakPtrFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolving the build error Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/ipc_echo.cc

diff --git a/content/shell/renderer/ipc_echo.cc b/content/shell/renderer/ipc_echo.cc

index 5eb48007ccf19bc55150445e4d9f5da5bdffedd0..5e41d98337fb09d12c4d425fbbd63bba80051118 100644

--- a/content/shell/renderer/ipc_echo.cc

+++ b/content/shell/renderer/ipc_echo.cc

@@ -82,9 +82,9 @@ void IPCEchoBindings::Install(base::WeakPtr<IPCEcho> echo,

IPCEcho::IPCEcho(blink::WebDocument document,

IPC::Sender* sender,

int routing_id)

- : weak_factory_(this),

- document_(document), sender_(sender), routing_id_(routing_id),

- last_echo_id_(0) {

+ : document_(document), sender_(sender), routing_id_(routing_id),

+ last_echo_id_(0),

+ weak_factory_(this) {

}

IPCEcho::~IPCEcho() {

« no previous file with comments | « content/shell/renderer/ipc_echo.h ('k') | content/test/accessibility_browser_test_utils.h » ('j') | no next file with comments »