Fix incorrect WebMediaPlayerDelegate notifications.

Fix incorrect WebMediaPlayerDelegate notifications.

These notifications are used by the browser to manager power save
blocking, inaccuracies will result in erroneously holding blockers
after playback has stopped.

BUG=43667, 367785
TEST=DCHECKs in WebContentsImpl no longer fire.

Committed: https://crrev.com/6d269edd075d8b9b0f64c6438313c1f8ff2248dd
Cr-Commit-Position: refs/heads/master@{#294468}

[DaleCurtis, 2014-09-11 19:08:29]

dalecurtis@chromium.org changed reviewers:
+ acolwell@chromium.org

[DaleCurtis, 2014-09-11 19:08:29]

I'm open to testing suggestions, this caused my other patch set to be reverted
since it adds DCHECKs which verify this behavior:

https://codereview.chromium.org/562863002/

[acolwell GONE FROM CHROMIUM, 2014-09-11 19:23:25]

lgtm % nit

https://codereview.chromium.org/564943002/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/564943002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:1298: else if
(was_playing)
nit: Don't you need && !is_playing_ here so you only call this on the
transition? Either that or just put a "if (is_playing == is_playing_) return;"
at the top of the method ?

[DaleCurtis, 2014-09-11 19:28:01]

https://codereview.chromium.org/564943002/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/564943002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:1298: else if
(was_playing)
On 2014/09/11 19:23:25, acolwell_leaving_chromium_9-23 wrote:
> nit: Don't you need && !is_playing_ here so you only call this on the
> transition? Either that or just put a "if (is_playing == is_playing_) return;"
> at the top of the method ?

Done.

[DaleCurtis, 2014-09-11 19:38:03]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-09-11 19:55:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/564943002/20001

[commit-bot: I haz the power, 2014-09-11 21:22:27]

Committed patchset #2 (id:20001) as 5a0ad76daccc0582ffd5aea1c929a264cd14244a

[commit-bot: I haz the power, 2014-09-11 21:40:53]

Patchset 2 (id:??) landed as
https://crrev.com/6d269edd075d8b9b0f64c6438313c1f8ff2248dd
Cr-Commit-Position: refs/heads/master@{#294468}