content/renderer/media/android/webmediaplayer_android.cc - Issue 564943002: Fix incorrect WebMediaPlayerDelegate notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.cc

Issue 564943002: Fix incorrect WebMediaPlayerDelegate notifications. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@psb

Patch Set: Fix comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/android/webmediaplayer_android.cc

diff --git a/content/renderer/media/android/webmediaplayer_android.cc b/content/renderer/media/android/webmediaplayer_android.cc

index 048994912aa7377092e315f14cfd0e39924acb5b..531311a00682af072f3e9288815bdcf91523670f 100644

--- a/content/renderer/media/android/webmediaplayer_android.cc

+++ b/content/renderer/media/android/webmediaplayer_android.cc

@@ -1289,8 +1289,9 @@ void WebMediaPlayerAndroid::setPoster(const blink::WebURL& poster) {

}

void WebMediaPlayerAndroid::UpdatePlayingState(bool is_playing) {

+ const bool was_playing = is_playing_;

is_playing_ = is_playing;

- if (!delegate_)

+ if (!delegate_ || was_playing == is_playing_)

return;

if (is_playing)

delegate_->DidPlay(this);

« no previous file with comments | « no previous file | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »