Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 564903002: Merge GpuCommandBufferMsg_SetLatencyInfo into GpuCommandBufferMsg_AsyncFlush (Closed)

Created:
6 years, 3 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Merge GpuCommandBufferMsg_SetLatencyInfo into GpuCommandBufferMsg_AsyncFlush GpuCommandBufferMsg_SetLatencyInfo is used to send current frame's latencyinfo to gpu. We can piggyback the latencyinfo in GpuCommandBufferMsg_AsyncFlush so eliminate the extra IPC. BUG=404650 TEST=check trace that now GLRenderer::SwapBuffers only sends 2 IPC messages, i.e. AsyncFlush and Echo. And LatencyInfo tracking is still working. Committed: https://crrev.com/ef0850f4739a1d3b440495f318dc349c162edf4e Cr-Commit-Position: refs/heads/master@{#294895}

Patch Set 1 #

Patch Set 2 : remove ShallowFlushCHROMIUM() in CompositorOutputSurface::SwapBuffers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -54 lines) Patch
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/common/gpu/gpu_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_channel.cc View 3 chunks +4 lines, -24 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 4 chunks +11 lines, -13 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +4 lines, -7 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Yufeng Shen (Slow to review)
6 years, 3 months ago (2014-09-11 17:58:52 UTC) #2
jbauman
lgtm
6 years, 3 months ago (2014-09-11 18:54:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564903002/1
6 years, 3 months ago (2014-09-11 19:56:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10429)
6 years, 3 months ago (2014-09-11 20:38:16 UTC) #7
Yufeng Shen (Slow to review)
+ jln@ for content/common/gpu/gpu_messages.h John, I also removed the ShallowFlushCHROMIUM() call from GpuBrowserCompositorOutputSurface::SwapBuffers and CompositorOutputSurface::SwapBuffers
6 years, 3 months ago (2014-09-11 20:42:03 UTC) #9
jln (very slow on Chromium)
content/common/gpu/gpu_messages.h lgtm, sorry for the delay.
6 years, 3 months ago (2014-09-15 19:31:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564903002/20001
6 years, 3 months ago (2014-09-15 19:34:29 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as cd843743be9331e48372909ad73aa6dfe956686b
6 years, 3 months ago (2014-09-15 21:32:35 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 21:44:25 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef0850f4739a1d3b440495f318dc349c162edf4e
Cr-Commit-Position: refs/heads/master@{#294895}

Powered by Google App Engine
This is Rietveld 408576698