Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 564893002: DevTools: [Console] fix selection of all console messages (Closed)

Created:
6 years, 3 months ago by lushnikov
Modified:
6 years, 3 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [Console] fix selection of all console messages It turns out that selection of all elements in console (aka Ctrl-A) works properly only if the last element in viewport DOM is a block element with some text. BUG=410899 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M LayoutTests/inspector/console/console-viewport-selection.html View 1 chunk +18 lines, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-viewport-selection-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
lushnikov
Please, take a look For future reference: the culprit in WebCore seems to be hidden ...
6 years, 3 months ago (2014-09-11 17:01:55 UTC) #1
vsevik
lgtm Is it possible to reproduce this in older versions by opening the modern remote ...
6 years, 3 months ago (2014-09-11 18:44:11 UTC) #2
lushnikov
Sure, to the extent of support of some "modern" features we use in the front-end ...
6 years, 3 months ago (2014-09-11 18:52:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564893002/1
6 years, 3 months ago (2014-09-11 18:53:49 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 20:58:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181850

Powered by Google App Engine
This is Rietveld 408576698