Source/devtools/front_end/console/ConsoleView.js - Issue 564893002: DevTools: [Console] fix selection of all console messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/console/ConsoleView.js

Issue 564893002: DevTools: [Console] fix selection of all console messages (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/console/console-viewport-selection-expected.txt ('k') | Source/devtools/front_end/inspectorStyle.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/console/ConsoleView.js

diff --git a/Source/devtools/front_end/console/ConsoleView.js b/Source/devtools/front_end/console/ConsoleView.js

index aaef5d69e36f3bda53925e0e26d8aae4e4f807a0..fe6e457f6b8abf6246637761d029267d3c2b7f02 100644

--- a/Source/devtools/front_end/console/ConsoleView.js

+++ b/Source/devtools/front_end/console/ConsoleView.js

@@ -103,6 +103,10 @@ WebInspector.ConsoleView = function()

this._promptElement.id = "console-prompt";

this._promptElement.spellcheck = false;

+ // FIXME: This is a workaround for the selection machinery bug. See crbug.com/410899

+ var selectAllFixer = this._messagesElement.createChild("div", "console-view-fix-select-all");

+ selectAllFixer.textContent = ".";

this._showAllMessagesCheckbox = new WebInspector.StatusBarCheckbox(WebInspector.UIString("Show all messages"));

this._showAllMessagesCheckbox.inputElement.checked = true;

this._showAllMessagesCheckbox.inputElement.addEventListener("change", this._updateMessageList.bind(this), false);