Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 564863002: ES6: String(symbol) should work like symbol.toString (Closed)

Created:
6 years, 3 months ago by arv (Not doing code reviews)
Modified:
6 years, 3 months ago
Reviewers:
rossberg
CC:
v8-dev, adamk
Project:
v8
Visibility:
Public.

Description

ES6: String(symbol) should work like symbol.toString Using String as a function and passing a symbol should return the same value as if Symbol.prototype.toString was called. http://people.mozilla.org/~jorendorff/es6-draft.html#sec-string-constructor-string-value BUG=v8:3554 LOG=Y R=rossberg@chromium.org, rossberg Committed: https://code.google.com/p/v8/source/detail?r=23923

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/string.js View 1 1 chunk +4 lines, -3 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/private.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
arv (Not doing code reviews)
6 years, 3 months ago (2014-09-11 16:04:31 UTC) #1
rossberg
https://codereview.chromium.org/564863002/diff/1/src/string.js File src/string.js (right): https://codereview.chromium.org/564863002/diff/1/src/string.js#newcode15 src/string.js:15: if (%_ArgumentsLength() == 0) return ''; We could avoid ...
6 years, 3 months ago (2014-09-12 12:56:38 UTC) #2
arv (Not doing code reviews)
Code review feedback
6 years, 3 months ago (2014-09-12 15:24:27 UTC) #3
arv (Not doing code reviews)
PTAL
6 years, 3 months ago (2014-09-12 15:25:21 UTC) #4
rossberg
lgtm
6 years, 3 months ago (2014-09-12 15:32:09 UTC) #5
arv (Not doing code reviews)
6 years, 3 months ago (2014-09-12 16:17:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23923 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698