test/mjsunit/harmony/private.js - Issue 564863002: ES6: String(symbol) should work like symbol.toString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mjsunit/harmony/private.js

Issue 564863002: ES6: String(symbol) should work like symbol.toString (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Code review feedback Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/mjsunit/harmony/private.js

diff --git a/test/mjsunit/harmony/private.js b/test/mjsunit/harmony/private.js

index 4b29fd863ed385e35533365646f6bd08d6608e84..218094c3d50632fb21f2c97e9403fdde883cd681 100644

--- a/test/mjsunit/harmony/private.js

+++ b/test/mjsunit/harmony/private.js

@@ -83,7 +83,8 @@ TestConstructor()

function TestToString() {

for (var i in symbols) {

- assertThrows(function() { String(symbols[i]) }, TypeError)

+ assertThrows(function() {new String(symbols[i]) }, TypeError)

+ assertEquals(symbols[i].toString(), String(symbols[i]))

assertThrows(function() { symbols[i] + "" }, TypeError)

assertTrue(isValidSymbolString(symbols[i].toString()))

assertTrue(isValidSymbolString(Object(symbols[i]).toString()))

« no previous file with comments | « test/mjsunit/es6/symbols.js ('k') | no next file » | no next file with comments »