Fix conversion to WebServiceWorkerResponse headers.

Fix conversion to WebServiceWorkerResponse headers.

When converting from Response headers to WebServiceWorkerResponse headers the fields aren't coalesced.  This CL adds coalescing by using appendHeader instead of setHeader.

A similar CL for WebServiceWorkerRequest headers is here: https://codereview.chromium.org/578763003

BUG=415109
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182364

[jkarlin, 2014-09-17 14:12:57]

jkarlin@chromium.org changed reviewers:
+ horo@chromium.org

[jkarlin, 2014-09-17 14:12:58]

Thanks!

[jkarlin, 2014-09-17 14:19:03]

jkarlin@chromium.org changed reviewers:
+ jochen@chromium.org

[jkarlin, 2014-09-17 14:19:04]

jochen@chromium.org: Please review changes in the platform/ directories. 
Thanks!

[horo, 2014-09-17 21:55:18]

On 2014/09/17 14:12:58, jkarlin wrote:
> Thanks!

Could you please add LayoutTest using XMLHttpRequest's getResponseHeader?

[jkarlin, 2014-09-18 14:25:04]

On 2014/09/17 21:55:18, horo wrote:
> On 2014/09/17 14:12:58, jkarlin wrote:
> > Thanks!
> 
> Could you please add LayoutTest using XMLHttpRequest's getResponseHeader?

What would this test do?  What is it testing for?

[jkarlin, 2014-09-18 14:25:35]

I've removed the lower() restriction.  PTAL.

[jochen (gone - plz use gerrit), 2014-09-18 18:36:49]

lgtm, but please wait for horo's lgtm as well

[horo, 2014-09-19 03:21:26]

On 2014/09/18 14:25:04, jkarlin wrote:
> On 2014/09/17 21:55:18, horo wrote:
> > On 2014/09/17 14:12:58, jkarlin wrote:
> > > Thanks!
> > 
> > Could you please add LayoutTest using XMLHttpRequest's getResponseHeader?
> 
> What would this test do?  What is it testing for?

Like this:
In ServiceWoker:
    e.respondWith(new Response("foo", { headers: [['a', 'x'], ['a', 'y']] }));
In the page:
  var xhr = new XMLHttpRequest();
  xhr.addEventListener('load', function() {
      assert_equals('x, y', xhr.getResponseHeader('a'));
    }, false);
  xhr.open('GET', 'test');
  xhr.send();

[jkarlin, 2014-09-19 19:30:53]

On 2014/09/19 03:21:26, horo wrote:
> On 2014/09/18 14:25:04, jkarlin wrote:
> > On 2014/09/17 21:55:18, horo wrote:
> > > On 2014/09/17 14:12:58, jkarlin wrote:
> > > > Thanks!
> > > 
> > > Could you please add LayoutTest using XMLHttpRequest's getResponseHeader?
> > 
> > What would this test do?  What is it testing for?
> 
> Like this:
> In ServiceWoker:
>     e.respondWith(new Response("foo", { headers: [['a', 'x'], ['a', 'y']] }));
> In the page:
>   var xhr = new XMLHttpRequest();
>   xhr.addEventListener('load', function() {
>       assert_equals('x, y', xhr.getResponseHeader('a'));
>     }, false);
>   xhr.open('GET', 'test');
>   xhr.send();

Done. PTAL.

[horo, 2014-09-20 01:35:17]

lgtm
Thank you!

[jkarlin, 2014-09-20 02:04:34]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-09-20 02:05:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/564773004/100001

[commit-bot: I haz the power, 2014-09-20 02:11:24]

Committed patchset #6 (id:100001) as 182364