Source/modules/serviceworkers/FetchResponseData.cpp - Issue 564773004: Fix conversion to WebServiceWorkerResponse headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/FetchResponseData.cpp

Issue 564773004: Fix conversion to WebServiceWorkerResponse headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added xhr end-to-end test Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/fetch-response-xhr-worker.js ('k') | Source/modules/serviceworkers/Response.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/FetchResponseData.cpp

diff --git a/Source/modules/serviceworkers/FetchResponseData.cpp b/Source/modules/serviceworkers/FetchResponseData.cpp

index 5f45dda7ff92e57fbd68049f5dd67a64616c9eb1..df4cc1e09bb44cefc8b9b40f72064db463c8a439 100644

--- a/Source/modules/serviceworkers/FetchResponseData.cpp

+++ b/Source/modules/serviceworkers/FetchResponseData.cpp

@@ -91,7 +91,7 @@ void FetchResponseData::populateWebServiceWorkerResponse(WebServiceWorkerRespons

response.setStatusText(statusMessage());

for (size_t i = 0; i < headerList()->size(); ++i) {

const FetchHeaderList::Header* header = headerList()->list()[i].get();

- response.setHeader(header->first, header->second);

+ response.appendHeader(header->first, header->second);

}

response.setBlobDataHandle(blobDataHandle());

}