Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 564553002: When we switch tabs in chrome, the tab being switched away from gets hidden/shown/hidden. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NULL root window check Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/native/native_view_host_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_aura.cc
diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc
index b436c8eeeb13e64bcf76829b8827521254693b5f..a7a71687e0d6847e9b2358a003a2d36f197fa18b 100644
--- a/ui/views/widget/native_widget_aura.cc
+++ b/ui/views/widget/native_widget_aura.cc
@@ -1148,8 +1148,10 @@ void NativeWidgetPrivate::ReparentNativeView(gfx::NativeView native_view,
// matches our previous behaviour; the global stacking client would almost
// always reattach the window to the same RootWindow.
aura::Window* root_window = native_view->GetRootWindow();
- aura::client::ParentWindowWithContext(
- native_view, root_window, root_window->GetBoundsInScreen());
+ if (root_window) {
sky 2014/09/12 21:27:05 This makes me nervous. See big comment above this.
ananta 2014/09/14 01:30:44 As per discussion, added code to show hide the Web
+ aura::client::ParentWindowWithContext(
+ native_view, root_window, root_window->GetBoundsInScreen());
+ }
}
// And now, notify them that they have a brand new parent.
« no previous file with comments | « ui/views/controls/native/native_view_host_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698