ui/views/controls/native/native_view_host_unittest.cc - Issue 564553002: When we switch tabs in chrome, the tab being switched away from gets hidden/shown/hidden.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/native/native_view_host_unittest.cc

Issue 564553002: When we switch tabs in chrome, the tab being switched away from gets hidden/shown/hidden. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: NULL root window check Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/views/controls/native/native_view_host_aura_unittest.cc ('k') | ui/views/widget/native_widget_aura.cc » ('j') | ui/views/widget/native_widget_aura.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/native/native_view_host_unittest.cc

diff --git a/ui/views/controls/native/native_view_host_unittest.cc b/ui/views/controls/native/native_view_host_unittest.cc

index e77fd358bf5827b987f1649eb50e93d9143ffd80..33743129d42fce06cf4c868e4ffbc3d00b6555a8 100644

--- a/ui/views/controls/native/native_view_host_unittest.cc

+++ b/ui/views/controls/native/native_view_host_unittest.cc

@@ -147,13 +147,10 @@ TEST_F(NativeViewHostTest, NativeViewHierarchyChanged) {

// Detaching should send a NativeViewHierarchyChanged() notification and

// change the parent.

host->Detach();

-#if defined(USE_AURA)

- // Two notifications are generated from removing the native view from the

- // clipping window and then reparenting it to the root window.

- EXPECT_EQ(2, test_view->notification_count());

-#else

+ // One notification is generated from reparenting the native view to the root

+ // window.

EXPECT_EQ(1, test_view->notification_count());

-#endif

EXPECT_NE(toplevel()->GetNativeView(),

GetNativeParent(child->GetNativeView()));

test_view->ResetCount();