Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 564493002: Added test for non cached ETC1

Created:
6 years, 3 months ago by sugoi1
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Added test for non cached ETC1 BUG=skia: Committed: https://skia.googlesource.com/skia/+/d9ec549071581d9d1dc2e5fac3163305ae935a39

Patch Set 1 #

Total comments: 5

Patch Set 2 : Added this-> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M gm/etc1bitmap.cpp View 1 5 chunks +23 lines, -0 lines 0 comments Download
M src/gpu/SkGr.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sugoi1
https://codereview.chromium.org/564493002/diff/1/src/gpu/SkGr.cpp File src/gpu/SkGr.cpp (left): https://codereview.chromium.org/564493002/diff/1/src/gpu/SkGr.cpp#oldcode327 src/gpu/SkGr.cpp:327: cache Missed that in the initial patch, oops. Now, ...
6 years, 3 months ago (2014-09-10 19:31:28 UTC) #2
robertphillips
lgtm + nits https://codereview.chromium.org/564493002/diff/1/gm/etc1bitmap.cpp File gm/etc1bitmap.cpp (right): https://codereview.chromium.org/564493002/diff/1/gm/etc1bitmap.cpp#newcode86 gm/etc1bitmap.cpp:86: str.append(this->fileExtension()); this-> ? https://codereview.chromium.org/564493002/diff/1/gm/etc1bitmap.cpp#newcode117 gm/etc1bitmap.cpp:117: this-> ...
6 years, 3 months ago (2014-09-10 20:29:49 UTC) #4
sugoi1
https://codereview.chromium.org/564493002/diff/1/gm/etc1bitmap.cpp File gm/etc1bitmap.cpp (right): https://codereview.chromium.org/564493002/diff/1/gm/etc1bitmap.cpp#newcode86 gm/etc1bitmap.cpp:86: str.append(this->fileExtension()); On 2014/09/10 20:29:48, robertphillips wrote: > this-> ? ...
6 years, 3 months ago (2014-09-10 20:32:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/564493002/20001
6 years, 3 months ago (2014-09-10 20:33:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d9ec549071581d9d1dc2e5fac3163305ae935a39
6 years, 3 months ago (2014-09-10 20:40:23 UTC) #8
bungeman-skia
6 years, 3 months ago (2014-09-10 21:59:12 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/559093003/ by bungeman@google.com.

The reason for reverting is: This is causing dm and gm to crash on the Win8 7770
bots, for example

http://108.170.220.120:10117/builders/Test-Win8-ShuttleA-HD7770-x86-Debug/bui...

An example stack trace looks like

[13:46:16.260000]   -1M drawing... extractbitmap [600 600]
[13:46:16.760000]   -1M drawing... etc1bitmap_npot [124 124]
[13:46:16.760000]   -1M drawing... etc1bitmap_r11.ktx [128 128]
[13:46:16.760000]   -1M drawing... etc1bitmap_ktx [128 128]
[13:46:16.760000]   -1M drawing... etc1bitmap_pkm_volatile [128 128]
[13:46:16.760000] 
[13:46:16.760000] Caught exception 3221225477 EXCEPTION_ACCESS_VIOLATION
[13:46:16.760000] sk_gr_allocate_texture +c9
[13:46:16.760000] load_etc1_texture +1dd
[13:46:16.760000] sk_gr_create_bitmap_texture +199
[13:46:16.760000] GrLockAndRefCachedBitmapTexture +ad
[13:46:16.760000] SkGpuDevice::SkAutoCachedTexture::set +5d
[13:46:16.760000] SkGpuDevice::SkAutoCachedTexture::SkAutoCachedTexture +65
[13:46:16.760000] SkGpuDevice::internalDrawBitmap +8e
[13:46:16.760000] SkGpuDevice::drawBitmapCommon +608
[13:46:16.760000] SkGpuDevice::drawBitmap +79
[13:46:16.760000] SkCanvas::internalDrawBitmap +11b
[13:46:16.760000] SkCanvas::drawBitmap +d3
[13:46:16.760000] skiagm::ETC1BitmapGM::onDraw +140
[13:46:16.760000] skiagm::GM::drawContent +3c
[13:46:16.760000] skiagm::GM::draw +24
[13:46:16.760000] GMMain::invokeGM +63
[13:46:16.760000] GMMain::generate_image +186
[13:46:16.760000] GMMain::test_drawing +5b
[13:46:16.760000] run_multiple_configs +2f9
[13:46:16.760000] tool_main +75d
[13:46:16.760000] main +16
[13:46:16.760000] __tmainCRTStartup +199
[13:46:16.760000] mainCRTStartup +d
[13:46:16.760000] BaseThreadInitThunk +e
[13:46:16.760000] RtlInitializeExceptionChain +84
[13:46:16.760000] RtlInitializeExceptionChain +5a.

Powered by Google App Engine
This is Rietveld 408576698