Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 564463002: Encoding API: Add TextDecodeOptions and TextDecoderOptions (Closed)

Created:
6 years, 3 months ago by bashi
Modified:
6 years, 3 months ago
Reviewers:
haraken, jsbell
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@dic-webmidi
Project:
blink
Visibility:
Public.

Description

Encoding API: Add TextDecodeOptions and TextDecoderOptions Replacing generic Dictionary. No changes in behavior. Tests under fast/encoding cover this change. BUG=403150 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181890

Patch Set 1 #

Patch Set 2 : Pointers -> References #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
A + Source/modules/encoding/TextDecodeOptions.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/encoding/TextDecoder.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M Source/modules/encoding/TextDecoder.cpp View 1 4 chunks +10 lines, -13 lines 0 comments Download
M Source/modules/encoding/TextDecoder.idl View 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/modules/encoding/TextDecoderOptions.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
bashi
jsbell@, Haraken-san, Could you take a look? This CL depends on https://codereview.chromium.org/547383004/ to build (GYP/GN ...
6 years, 3 months ago (2014-09-10 14:32:43 UTC) #2
haraken
LGTM, but let's wait for an approval of jsbell@.
6 years, 3 months ago (2014-09-10 15:36:08 UTC) #3
jsbell
lgtm - this is awesome!
6 years, 3 months ago (2014-09-10 17:05:53 UTC) #4
bashi
On 2014/09/10 17:05:53, jsbell wrote: > lgtm - this is awesome! Thank you for review!
6 years, 3 months ago (2014-09-12 07:20:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564463002/40001
6 years, 3 months ago (2014-09-12 07:20:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26776)
6 years, 3 months ago (2014-09-12 09:11:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564463002/40001
6 years, 3 months ago (2014-09-12 09:17:04 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 10:43:56 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 181890

Powered by Google App Engine
This is Rietveld 408576698