Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1728)

Unified Diff: Source/modules/encoding/TextDecoder.h

Issue 564463002: Encoding API: Add TextDecodeOptions and TextDecoderOptions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@dic-webmidi
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/encoding/TextDecodeOptions.idl ('k') | Source/modules/encoding/TextDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/encoding/TextDecoder.h
diff --git a/Source/modules/encoding/TextDecoder.h b/Source/modules/encoding/TextDecoder.h
index 2a3df73dd48703644eab3c3698275536286ba0aa..acc940f6130f514195e0aca5c739c87fa6e9f10b 100644
--- a/Source/modules/encoding/TextDecoder.h
+++ b/Source/modules/encoding/TextDecoder.h
@@ -31,8 +31,9 @@
#ifndef TextDecoder_h
#define TextDecoder_h
-#include "bindings/core/v8/Dictionary.h"
#include "bindings/core/v8/ScriptWrappable.h"
+#include "modules/encoding/TextDecodeOptions.h"
+#include "modules/encoding/TextDecoderOptions.h"
#include "platform/heap/Handle.h"
#include "wtf/ArrayBufferView.h"
#include "wtf/text/TextCodec.h"
@@ -46,15 +47,15 @@ class ExceptionState;
class TextDecoder FINAL : public GarbageCollectedFinalized<TextDecoder>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
- static TextDecoder* create(const String& label, const Dictionary&, ExceptionState&);
+ static TextDecoder* create(const String& label, const TextDecoderOptions&, ExceptionState&);
~TextDecoder();
// Implement the IDL
String encoding() const;
bool fatal() const { return m_fatal; }
bool ignoreBOM() const { return m_ignoreBOM; }
- String decode(ArrayBufferView*, const Dictionary&, ExceptionState&);
- String decode(ExceptionState& exceptionState) { return decode(0, Dictionary(), exceptionState); }
+ String decode(ArrayBufferView*, const TextDecodeOptions&, ExceptionState&);
+ String decode(ExceptionState&);
void trace(Visitor*) { }
« no previous file with comments | « Source/modules/encoding/TextDecodeOptions.idl ('k') | Source/modules/encoding/TextDecoder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698