Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 564373006: android: Disable transfer thread on Adreno 420 (Closed)

Created:
6 years, 3 months ago by no sievers
Modified:
6 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@clankium
Project:
chromium
Visibility:
Public.

Description

android: Disable transfer thread on Adreno 420 BUG=407184, 386735 Committed: https://crrev.com/b46831d14f773db39a3e90dc01281bff3c269649 Cr-Commit-Position: refs/heads/master@{#294983}

Patch Set 1 #

Total comments: 1

Patch Set 2 : avoid test expectation change #

Patch Set 3 : null check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -23 lines) Patch
M gpu/command_buffer/service/async_pixel_transfer_manager_android.cc View 1 2 2 chunks +47 lines, -23 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
no sievers
ptal
6 years, 3 months ago (2014-09-15 21:24:20 UTC) #2
epennerAtGoogle
LGTM (but see comment about tests) https://codereview.chromium.org/564373006/diff/1/gpu/command_buffer/service/async_pixel_transfer_manager_android.cc File gpu/command_buffer/service/async_pixel_transfer_manager_android.cc (right): https://codereview.chromium.org/564373006/diff/1/gpu/command_buffer/service/async_pixel_transfer_manager_android.cc#newcode68 gpu/command_buffer/service/async_pixel_transfer_manager_android.cc:68: GpuType gpu = ...
6 years, 3 months ago (2014-09-16 00:07:15 UTC) #4
no sievers
On 2014/09/16 00:07:15, epennerAtGoogle wrote: > LGTM (but see comment about tests) > > https://codereview.chromium.org/564373006/diff/1/gpu/command_buffer/service/async_pixel_transfer_manager_android.cc ...
6 years, 3 months ago (2014-09-16 00:18:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564373006/40001
6 years, 3 months ago (2014-09-16 00:37:42 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as d657cf897ed710548eacafde593bc86bd948addf
6 years, 3 months ago (2014-09-16 02:25:07 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 02:28:44 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b46831d14f773db39a3e90dc01281bff3c269649
Cr-Commit-Position: refs/heads/master@{#294983}

Powered by Google App Engine
This is Rietveld 408576698