android: Disable transfer thread on Adreno 420

gpu/command_buffer/service/async_pixel_transfer_manager_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/async_pixel_transfer_manager.h"
 
 #include "base/debug/trace_event.h"
 #include "base/sys_info.h"
 #include "gpu/command_buffer/service/async_pixel_transfer_manager_egl.h"
 #include "gpu/command_buffer/service/async_pixel_transfer_manager_idle.h"
 #include "gpu/command_buffer/service/async_pixel_transfer_manager_stub.h"
 #include "gpu/command_buffer/service/async_pixel_transfer_manager_sync.h"
 #include "ui/gl/gl_context.h"
 #include "ui/gl/gl_implementation.h"
 
 namespace gpu {
 namespace {
 
-bool IsBroadcom() {
-  const char* vendor = reinterpret_cast<const char*>(glGetString(GL_VENDOR));
-  if (vendor)
-    return std::string(vendor).find("Broadcom") != std::string::npos;
-  return false;
-}
+enum GpuType {
+  GPU_BROADCOM,
+  GPU_IMAGINATION,
+  GPU_NVIDIA_ES31,
+  GPU_ADRENO_420,
+  GPU_OTHER,
+};
 
-bool IsImagination() {
-  const char* vendor = reinterpret_cast<const char*>(glGetString(GL_VENDOR));
-  if (vendor)
-    return std::string(vendor).find("Imagination") != std::string::npos;
-  return false;
-}
+GpuType GetGpuType() {
+  const std::string vendor(
+      reinterpret_cast<const char*>(glGetString(GL_VENDOR)));
+  const std::string renderer(
+      reinterpret_cast<const char*>(glGetString(GL_RENDERER)));
+  const std::string version(
+      reinterpret_cast<const char*>(glGetString(GL_VERSION)));
 
-bool IsNvidia31() {
-  const char* vendor = reinterpret_cast<const char*>(glGetString(GL_VENDOR));
-  const char* version = reinterpret_cast<const char*>(glGetString(GL_VERSION));
-  return vendor && version &&
-         std::string(vendor).find("NVIDIA") != std::string::npos &&
-         std::string(version).find("OpenGL ES 3.1") != std::string::npos;
+  if (vendor.find("Broadcom") != std::string::npos)
+    return GPU_BROADCOM;
+
+  if (vendor.find("Imagination") != std::string::npos)
+    return GPU_IMAGINATION;
+
+  if (vendor.find("NVIDIA") != std::string::npos &&
+      version.find("OpenGL ES 3.1") != std::string::npos) {
+    return GPU_NVIDIA_ES31;
+  }
+
+  if (vendor.find("Qualcomm") != std::string::npos &&
+      renderer.find("Adreno (TM) 420") != std::string::npos) {
+    return GPU_ADRENO_420;
+  }
+
+  return GPU_OTHER;
 }
 
 }
 
 // We only used threaded uploads when we can:
 // - Create EGLImages out of OpenGL textures (EGL_KHR_gl_texture_2D_image)
 // - Bind EGLImages to OpenGL textures (GL_OES_EGL_image)
 // - Use fences (to test for upload completion).
 // - The heap size is large enough.
 // TODO(kaanb|epenner): Remove the IsImagination() check pending the
 // resolution of crbug.com/249147
 // TODO(kaanb|epenner): Remove the IsLowEndDevice() check pending the
 // resolution of crbug.com/271929
 AsyncPixelTransferManager* AsyncPixelTransferManager::Create(
     gfx::GLContext* context) {
-  TRACE_EVENT0("gpu", "AsyncPixelTransferManager::Create");
+  DCHECK(context->IsCurrent(NULL));
+  GpuType gpu = GetGpuType();

[epennerAtGoogle, 2014/09/16 00:07:15]

This will likely fail some unit tests. They are very picky about the exact GL
calls being expected.

It's easiest to just put the glGetString behind a HasExtension call (which will
be false in the test).

+  TRACE_EVENT1("gpu", "AsyncPixelTransferManager::Create", "type", gpu);
   switch (gfx::GetGLImplementation()) {
     case gfx::kGLImplementationEGLGLES2:
       DCHECK(context);
-      if (context->HasExtension("EGL_KHR_fence_sync") &&
+      if (!base::SysInfo::IsLowEndDevice() &&
+          context->HasExtension("EGL_KHR_fence_sync") &&
           context->HasExtension("EGL_KHR_image") &&
           context->HasExtension("EGL_KHR_image_base") &&
           context->HasExtension("EGL_KHR_gl_texture_2D_image") &&
           context->HasExtension("GL_OES_EGL_image") &&
-          !IsBroadcom() &&
-          !IsImagination() &&
-          !IsNvidia31() &&
-          !base::SysInfo::IsLowEndDevice()) {
+          gpu != GPU_BROADCOM &&
+          gpu != GPU_IMAGINATION &&
+          gpu != GPU_NVIDIA_ES31 &&
+          gpu != GPU_ADRENO_420) {
         return new AsyncPixelTransferManagerEGL;
       }
       return new AsyncPixelTransferManagerIdle;
     case gfx::kGLImplementationOSMesaGL:
       return new AsyncPixelTransferManagerIdle;
     case gfx::kGLImplementationMockGL:
       return new AsyncPixelTransferManagerStub;
     default:
       NOTREACHED();
       return NULL;
   }
 }
 
 }  // namespace gpu