Issue 564173002: (Telemetry) Rename Device.device_id to Device.guid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 564173002: (Telemetry) Rename Device.device_id to Device.guid (Closed)

Created:
6 years, 3 months ago by nednguyen

Modified:
6 years, 3 months ago

Reviewers:
nduca, tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

(Telemetry) Rename Device.device_id to Device.guid BUG=413637 Committed: https://crrev.com/3fca97f4ad235b7940949a3a53cfd8ca6835b110 Cr-Commit-Position: refs/heads/master@{#294651}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -10 lines)			Patch
M	tools/telemetry/telemetry/core/platform/__init__.py	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/core/platform/cros_device.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/platform/device.py	View	1 chunk	+6 lines, -6 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564173002/1

6 years, 3 months ago (2014-09-12 19:38:41 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 89efe7852822e24f4f300721bd6bc152af75c25f

6 years, 3 months ago (2014-09-12 20:38:41 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-12 20:44:37 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3fca97f4ad235b7940949a3a53cfd8ca6835b110
Cr-Commit-Position: refs/heads/master@{#294651}