Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: tools/telemetry/telemetry/core/platform/__init__.py

Issue 564173002: (Telemetry) Rename Device.device_id to Device.guid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/cros_device.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/platform/__init__.py
diff --git a/tools/telemetry/telemetry/core/platform/__init__.py b/tools/telemetry/telemetry/core/platform/__init__.py
index bca5da304bb798be1aa70bc5ac5036966a80afb1..80bf4932fb8135a83aec4b1b8276526a0b363f9c 100644
--- a/tools/telemetry/telemetry/core/platform/__init__.py
+++ b/tools/telemetry/telemetry/core/platform/__init__.py
@@ -61,20 +61,20 @@ def GetPlatformForDevice(device, logging=real_logging):
Args:
device: a device.Device instance.
"""
- if device.device_id not in _remote_platforms:
+ if device.guid not in _remote_platforms:
try:
if isinstance(device, cros_device.CrOSDevice):
cri = cros_interface.CrOSInterface(
device.host_name, device.ssh_identity)
cri.TryLogin()
- _remote_platforms[device.device_id] = (
+ _remote_platforms[device.guid] = (
Platform(cros_platform_backend.CrosPlatformBackend(cri)))
else:
raise ValueError('Unsupported device type')
except:
logging.error('Fail to create platform instance for %s.', device.name)
raise
- return _remote_platforms[device.device_id]
+ return _remote_platforms[device.guid]
class Platform(object):
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/cros_device.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698