Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 564153003: Browser Plugin: Don't crash browser when reloading crashed webview (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Browser Plugin: Don't crash browser when reloading crashed webview We were accessing a NULL RWHV on BrowserPluginGuest::SetFocus. This CL adds a guard to ensure we only attempt to set focus if we have a View. BUG=413874 Committed: https://crrev.com/66602da324d34c39337e14f583bb97c457072f0d Cr-Commit-Position: refs/heads/master@{#294674}

Patch Set 1 #

Patch Set 2 : Update BrowserPluginGuest state even if NULL #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -5 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 2 chunks +35 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 chunks +6 lines, -4 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
Fady Samuel
6 years, 3 months ago (2014-09-12 20:47:53 UTC) #2
lazyboy
lgtm https://chromiumcodereview.appspot.com/564153003/diff/20001/content/browser/browser_plugin/browser_plugin_guest.cc File content/browser/browser_plugin/browser_plugin_guest.cc (right): https://chromiumcodereview.appspot.com/564153003/diff/20001/content/browser/browser_plugin/browser_plugin_guest.cc#newcode725 content/browser/browser_plugin/browser_plugin_guest.cc:725: RenderWidgetHost* rwh = rwhv ? rwhv->GetRenderWidgetHost() : NULL; ...
6 years, 3 months ago (2014-09-12 20:56:37 UTC) #3
Fady Samuel
CQ'ing. https://chromiumcodereview.appspot.com/564153003/diff/20001/content/browser/browser_plugin/browser_plugin_guest.cc File content/browser/browser_plugin/browser_plugin_guest.cc (right): https://chromiumcodereview.appspot.com/564153003/diff/20001/content/browser/browser_plugin/browser_plugin_guest.cc#newcode725 content/browser/browser_plugin/browser_plugin_guest.cc:725: RenderWidgetHost* rwh = rwhv ? rwhv->GetRenderWidgetHost() : NULL; ...
6 years, 3 months ago (2014-09-12 20:59:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564153003/20001
6 years, 3 months ago (2014-09-12 21:00:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d1619ce1926896e81b718c0a3e0e838a5348a267
6 years, 3 months ago (2014-09-12 22:04:10 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 22:09:37 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/66602da324d34c39337e14f583bb97c457072f0d
Cr-Commit-Position: refs/heads/master@{#294674}

Powered by Google App Engine
This is Rietveld 408576698