chrome/browser/apps/web_view_browsertest.cc - Issue 564153003: Browser Plugin: Don't crash browser when reloading crashed webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/web_view_browsertest.cc

Issue 564153003: Browser Plugin: Don't crash browser when reloading crashed webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update BrowserPluginGuest state even if NULL Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/test/data/extensions/platform_apps/web_view/shim/main.js » ('j') | content/browser/browser_plugin/browser_plugin_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/web_view_browsertest.cc

diff --git a/chrome/browser/apps/web_view_browsertest.cc b/chrome/browser/apps/web_view_browsertest.cc

index a62d3dcd3a41cf217ff7d6cf0be5272cc02861e0..979539134076614957034ab6aa17673368fbfa66 100644

--- a/chrome/browser/apps/web_view_browsertest.cc

+++ b/chrome/browser/apps/web_view_browsertest.cc

@@ -1187,7 +1187,11 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestLoadAbortNonWebSafeScheme) {

}

IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestReload) {

- TestHelper("testReload", "web_view/shim", NEEDS_TEST_SERVER);

+ TestHelper("testReload", "web_view/shim", NO_TEST_SERVER);

+IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestReloadAfterTerminate) {

+ TestHelper("testReloadAfterTerminate", "web_view/shim", NO_TEST_SERVER);

}

IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestGetProcessId) {

« no previous file with comments | « no previous file | chrome/test/data/extensions/platform_apps/web_view/shim/main.js » ('j') | content/browser/browser_plugin/browser_plugin_guest.cc » ('J')