Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 56413002: Fix spelling of "NaCl" in various places: "NaCL" is the wrong capitalisation (Closed)

Created:
7 years, 1 month ago by Mark Seaborn
Modified:
7 years, 1 month ago
CC:
chromium-reviews, viettrungluu+watch_chromium.org, tzik, jam, abarth-chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, binji, darin (slow to review), ben+mojo_chromium.org, kinuko+watch, Sam Clegg
Visibility:
Public.

Description

Fix spelling of "NaCl" in various places: "NaCL" is the wrong capitalisation BUG=none TEST=none TBR=ericu@chromium.org,sbc@chromium.org,aa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232550

Patch Set 1 #

Total comments: 2

Patch Set 2 : Undo translation change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M content/common/sandbox_mac_unittest_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/README View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/make_simple.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/nacl_io.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tools/compiler-wrapper.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tools/create_nmf.py View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/async_file_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_file_util.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mark Seaborn
7 years, 1 month ago (2013-11-01 18:47:36 UTC) #1
Sam Clegg
I've been meaning at a presubmit check for this :)
7 years, 1 month ago (2013-11-01 19:31:49 UTC) #2
Nick Bray (chromium)
A capital suggestion. LGTM, make sure you know what's going on with localization. https://codereview.chromium.org/56413002/diff/1/chrome/app/resources/generated_resources_pl.xtb File ...
7 years, 1 month ago (2013-11-01 21:12:57 UTC) #3
Mark Seaborn
https://codereview.chromium.org/56413002/diff/1/chrome/app/resources/generated_resources_pl.xtb File chrome/app/resources/generated_resources_pl.xtb (right): https://codereview.chromium.org/56413002/diff/1/chrome/app/resources/generated_resources_pl.xtb#newcode210 chrome/app/resources/generated_resources_pl.xtb:210: <translation id="7774497835322490043">Włącz kod pośredniczący debugowania przy użyciu GDB. Spowoduje ...
7 years, 1 month ago (2013-11-01 21:28:40 UTC) #4
kerz_chromium
On 2013/11/01 21:28:40, Mark Seaborn wrote: > https://codereview.chromium.org/56413002/diff/1/chrome/app/resources/generated_resources_pl.xtb > File chrome/app/resources/generated_resources_pl.xtb (right): > > https://codereview.chromium.org/56413002/diff/1/chrome/app/resources/generated_resources_pl.xtb#newcode210 ...
7 years, 1 month ago (2013-11-01 22:27:04 UTC) #5
Mark Seaborn
On 1 November 2013 15:27, <kerz@chromium.org> wrote: > On 2013/11/01 21:28:40, Mark Seaborn wrote: > ...
7 years, 1 month ago (2013-11-01 22:47:25 UTC) #6
kerz_chromium
On 2013/11/01 22:47:25, Mark Seaborn wrote: > On 1 November 2013 15:27, <mailto:kerz@chromium.org> wrote: > ...
7 years, 1 month ago (2013-11-01 22:49:19 UTC) #7
Mark Seaborn
+various OWNERS
7 years, 1 month ago (2013-11-01 22:55:29 UTC) #8
jln (very slow on Chromium)
lgtm
7 years, 1 month ago (2013-11-02 00:37:49 UTC) #9
Mark Seaborn
7 years, 1 month ago (2013-11-02 01:41:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r232550 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698