Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: Source/bindings/tests/results/modules/V8TestInterface5.cpp

Issue 564063002: Generate simple code for "trivial" conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/core/V8TestSpecialOperations.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/modules/V8TestInterface5.cpp
diff --git a/Source/bindings/tests/results/modules/V8TestInterface5.cpp b/Source/bindings/tests/results/modules/V8TestInterface5.cpp
index 7242e5b17450b28561364c2c13a1f1a43e8d770c..ddf700fbd5d29cd6cb3af8bc48ef73e2c9bb7d84 100644
--- a/Source/bindings/tests/results/modules/V8TestInterface5.cpp
+++ b/Source/bindings/tests/results/modules/V8TestInterface5.cpp
@@ -60,7 +60,7 @@ static void testInterfaceAttributeAttributeSetter(v8::Local<v8::Value> v8Value,
return;
}
TestInterface5Implementation* impl = V8TestInterface5::toImpl(holder);
- TONATIVE_VOID(TestInterface5Implementation*, cppValue, V8TestInterface5::toImplWithTypeCheck(info.GetIsolate(), v8Value));
+ TestInterface5Implementation* cppValue = V8TestInterface5::toImplWithTypeCheck(info.GetIsolate(), v8Value);
impl->setTestInterfaceAttribute(WTF::getPtr(cppValue));
}
@@ -346,13 +346,11 @@ static void voidMethodTestInterfaceEmptyArgMethod(const v8::FunctionCallbackInfo
TestInterface5Implementation* impl = V8TestInterface5::toImpl(info.Holder());
TestInterfaceEmpty* testInterfaceEmptyArg;
{
- v8::TryCatch block;
- V8RethrowTryCatchScope rethrow(block);
if (info.Length() > 0 && !V8TestInterfaceEmpty::hasInstance(info[0], info.GetIsolate())) {
V8ThrowException::throwTypeError(ExceptionMessages::failedToExecute("voidMethodTestInterfaceEmptyArg", "TestInterface5", "parameter 1 is not of type 'TestInterfaceEmpty'."), info.GetIsolate());
return;
}
- TONATIVE_VOID_INTERNAL(testInterfaceEmptyArg, V8TestInterfaceEmpty::toImplWithTypeCheck(info.GetIsolate(), info[0]));
+ testInterfaceEmptyArg = V8TestInterfaceEmpty::toImplWithTypeCheck(info.GetIsolate(), info[0]);
}
impl->voidMethodTestInterfaceEmptyArg(testInterfaceEmptyArg);
}
« no previous file with comments | « Source/bindings/tests/results/core/V8TestSpecialOperations.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698