Source/bindings/tests/results/core/V8TestSpecialOperations.cpp - Issue 564063002: Generate simple code for "trivial" conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

Issue 564063002: Generate simple code for "trivial" conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

diff --git a/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp b/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

index 17487d9936609502ee3cf4354e27936fa4e6e98a..9beb001cbee6e9976d43b3d75cf955a582432aad 100644

--- a/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

+++ b/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

@@ -100,7 +100,7 @@ static void namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value>

{

TestSpecialOperations* impl = V8TestSpecialOperations::toImpl(info.Holder());

TOSTRING_VOID(V8StringResource<>, propertyName, name);

- TONATIVE_VOID(Node*, propertyValue, V8Node::toImplWithTypeCheck(info.GetIsolate(), v8Value));

+ Node* propertyValue = V8Node::toImplWithTypeCheck(info.GetIsolate(), v8Value);

bool result = impl->anonymousNamedSetter(propertyName, propertyValue);

if (!result)

return;