Source/bindings/tests/results/core/V8TestInterfaceNotScriptWrappable.cpp - Issue 564063002: Generate simple code for "trivial" conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceNotScriptWrappable.cpp

Issue 564063002: Generate simple code for "trivial" conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceNode.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceNotScriptWrappable.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceNotScriptWrappable.cpp b/Source/bindings/tests/results/core/V8TestInterfaceNotScriptWrappable.cpp

index 59e90787606ad1c82dabd2e7e57cf38ddd37c283..59ff3c9ce48e35d09dba07c8bad0a033e026920f 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceNotScriptWrappable.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceNotScriptWrappable.cpp

@@ -45,7 +45,7 @@ static void attr1AttributeSetter(v8::Local<v8::Value> v8Value, const v8::Propert

{

v8::Handle<v8::Object> holder = info.Holder();

TestInterfaceNotScriptWrappable* impl = V8TestInterfaceNotScriptWrappable::toImpl(holder);

- TONATIVE_VOID(TestInterfaceNotScriptWrappable*, cppValue, V8TestInterfaceNotScriptWrappable::toImplWithTypeCheck(info.GetIsolate(), v8Value));

+ TestInterfaceNotScriptWrappable* cppValue = V8TestInterfaceNotScriptWrappable::toImplWithTypeCheck(info.GetIsolate(), v8Value);

impl->setAttr1(WTF::getPtr(cppValue));

}

@@ -65,9 +65,7 @@ static void funcMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

TestInterfaceNotScriptWrappable* impl = V8TestInterfaceNotScriptWrappable::toImpl(info.Holder());

TestInterfaceNotScriptWrappable* arg;

{

- v8::TryCatch block;

- V8RethrowTryCatchScope rethrow(block);

- TONATIVE_VOID_INTERNAL(arg, V8TestInterfaceNotScriptWrappable::toImplWithTypeCheck(info.GetIsolate(), info[0]));

+ arg = V8TestInterfaceNotScriptWrappable::toImplWithTypeCheck(info.GetIsolate(), info[0]);

}

impl->func(arg);

}