Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

Issue 564063002: Generate simple code for "trivial" conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp b/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
index dbaaff8b3bfeaf9cc3059e9ac180fa71caa5f85f..628aba0c292eb85170660aace018d0cfd0f767e9 100644
--- a/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
@@ -240,13 +240,11 @@ static void perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethod(con
TestInterfaceNode* impl = V8TestInterfaceNode::toImpl(info.Holder());
bool optionalBooleanArgument;
{
- v8::TryCatch block;
- V8RethrowTryCatchScope rethrow(block);
if (UNLIKELY(info.Length() <= 0)) {
v8SetReturnValueFast(info, WTF::getPtr(impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg()), impl);
return;
}
- TONATIVE_VOID_INTERNAL(optionalBooleanArgument, info[0]->BooleanValue());
+ optionalBooleanArgument = info[0]->BooleanValue();
}
v8SetReturnValueFast(info, WTF::getPtr(impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg(optionalBooleanArgument)), impl);
}
@@ -263,13 +261,11 @@ static void perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethodForM
TestInterfaceNode* impl = V8TestInterfaceNode::toImpl(info.Holder());
bool optionalBooleanArgument;
{
- v8::TryCatch block;
- V8RethrowTryCatchScope rethrow(block);
if (UNLIKELY(info.Length() <= 0)) {
v8SetReturnValueForMainWorld(info, WTF::getPtr(impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg()));
return;
}
- TONATIVE_VOID_INTERNAL(optionalBooleanArgument, info[0]->BooleanValue());
+ optionalBooleanArgument = info[0]->BooleanValue();
}
v8SetReturnValueForMainWorld(info, WTF::getPtr(impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg(optionalBooleanArgument)));
}

Powered by Google App Engine
This is Rietveld 408576698